Skip to content

fix(eth): return indexed block logsBloom - #13618

Merged
rjan90 merged 7 commits into
filecoin-project:masterfrom
shrirajpawar4:feat/calc-logbloom
Jun 17, 2026
Merged

fix(eth): return indexed block logsBloom#13618
rjan90 merged 7 commits into
filecoin-project:masterfrom
shrirajpawar4:feat/calc-logbloom

Conversation

@shrirajpawar4

@shrirajpawar4 shrirajpawar4 commented May 10, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Fixes #13546

Proposed Changes

  • Add a tipset_bloom table to the chain index DB for block-level ETH log blooms.
  • Add a migration for existing chain index DBs.
  • Compute and store tipset-level blooms while indexing actor events.
  • Store empty blooms for indexed tipsets with no events.
  • Rebuild/store blooms when previously reverted events are unreverted.
  • Delete bloom rows on revert.
  • Delete old bloom rows during chain index GC.
  • Expose GetTipsetBloom on the chain indexer.
  • Use indexed blooms when constructing ETH block responses for:
    • eth_getBlockByHash
    • eth_getBlockByNumber
    • new-head subscription block payloads
  • Preserve compatibility by falling back to the previous full bloom when no indexed bloom is available.
  • Extend TestTxReceiptBloom to cover receipt bloom, empty block bloom, block-by-hash bloom, and block-by-number bloom.

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz May 10, 2026
Comment thread chain/index/events.go Outdated
Comment thread chain/index/events.go
Comment thread chain/index/events.go Outdated
Comment thread chain/index/events.go
@shrirajpawar4
shrirajpawar4 marked this pull request as ready for review May 11, 2026 05:39
@shrirajpawar4
shrirajpawar4 requested a review from rvagg May 11, 2026 05:40
@Kubuxu
Kubuxu self-requested a review May 11, 2026 10:22
@shrirajpawar4

Copy link
Copy Markdown
Contributor Author

@Kubuxu can you take a look please

@Kubuxu

Kubuxu commented May 15, 2026

Copy link
Copy Markdown
Contributor

I started reviewing it, but I need to wrap my head around a few things.

@Kubuxu Kubuxu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one comment, LGTM.
I haven't really worked on this part of the code much before, but it looks good.

Comment thread chain/index/events.go
@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz May 20, 2026
@shrirajpawar4
shrirajpawar4 requested a review from hugomrdias May 29, 2026 02:27
@shrirajpawar4
shrirajpawar4 requested a review from Kubuxu June 4, 2026 10:53
@rjan90

rjan90 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Pushed a commit for addressing the changelog conflict, thanks for working on this @shrirajpawar4 - will merge this once checks passes now

@rjan90
rjan90 enabled auto-merge (squash) June 17, 2026 06:29
@rjan90
rjan90 merged commit 3865dcc into filecoin-project:master Jun 17, 2026
95 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Calculate and return logsBloom on eth_getBlock* API calls

5 participants