fix(cli): warn when --api overrides configured API listen address - #13670
Merged
rjan90 merged 2 commits intoJun 22, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
DeepCogNeural
changed the title
github-actions
Bot
dismissed
their stale review
June 19, 2026 17:17
PR title now matches the required format.
rvagg
approved these changes
Jun 22, 2026
github-project-automation
Bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lotus daemon --apioverrides the configuredAPI.ListenAddress--apiFixes #12545
Testing
gofmt -l cli/lotus/daemon.go cli/lotus/daemon_test.gogit diff --checkCGO_LDFLAGS="-L/opt/homebrew/lib" go test ./cli/lotus -run TestAPIFlagOverrideWarning -count=1CGO_LDFLAGS="-L/opt/homebrew/lib" go test ./cli/lotus -count=1