Promtail: Fix collecting userdata field from Windows Event Log#7461
Merged
Conversation
5 tasks
chaudum
approved these changes
Oct 19, 2022
chaudum
left a comment
chaudum
left a comment
Contributor
There was a problem hiding this comment.
Thanks for spotting and fixing the bug!
LGTM
Contributor
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
changhyuni
pushed a commit
to changhyuni/loki
that referenced
this pull request
Nov 8, 2022
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
MichelHollands
pushed a commit
that referenced
this pull request
Nov 10, 2022
**What this PR does / why we need it**: Windows Event Logs have an Event Message field that is intended for human eyes, and often contains data that already present in the event data XML. Omitting this field the same way we can already omit `user_data` and `event_data` can easily save a lot of bytes of data per event - Event ID 4264 alone has ~2KB of just text that is already present in `event_data`. **Which issue(s) this PR fixes**: Fixes #7395 **Special notes for your reviewer**: I also took the liberty to improve upon the existing test '`Test_renderEntries` by using unique values for each field rather than 10's everywhere. I expect this to conflict with my other PR, #7461.
latere-a-latere
added a commit
to latere-a-latere/loki
that referenced
this pull request
Nov 14, 2022
- PR grafana#7462 and grafana#7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved grafana#7602 to enhancements section of Promtail
5 tasks
vlad-diachenko
pushed a commit
that referenced
this pull request
Nov 29, 2022
… 2.7.x (#7690) Fixes the changelog. - PR #7462 and #7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved #7602 to enhancements section of Promtail
Abuelodelanada
pushed a commit
to canonical/loki
that referenced
this pull request
Dec 1, 2022
…na#7461) **What this PR does / why we need it**: The windows event log target for Promtail had a typo that led to `EventData` being assigned to `UserData`. This PR fixes this typo. **Which issue(s) this PR fixes**: Fixes grafana#6167
Abuelodelanada
pushed a commit
to canonical/loki
that referenced
this pull request
Dec 1, 2022
**What this PR does / why we need it**: Windows Event Logs have an Event Message field that is intended for human eyes, and often contains data that already present in the event data XML. Omitting this field the same way we can already omit `user_data` and `event_data` can easily save a lot of bytes of data per event - Event ID 4264 alone has ~2KB of just text that is already present in `event_data`. **Which issue(s) this PR fixes**: Fixes grafana#7395 **Special notes for your reviewer**: I also took the liberty to improve upon the existing test '`Test_renderEntries` by using unique values for each field rather than 10's everywhere. I expect this to conflict with my other PR, grafana#7461.
Abuelodelanada
pushed a commit
to canonical/loki
that referenced
this pull request
Dec 1, 2022
… 2.7.x (grafana#7690) Fixes the changelog. - PR grafana#7462 and grafana#7461 were **not** included in the 2.7.x release (they were submitted right after the cutoff and did not get backported) and accidentally ended up in the 2.7.x changelog. Moved them up to Main/Unreleased. - Moved grafana#7602 to enhancements section of Promtail
DylanGuedes
added
kind/bug
backport release-2.7.x
Contributor
|
Hello @DylanGuedes!
Please, if the current pull request addresses a bug fix, label it with the |
DylanGuedes
added
type/bug
DylanGuedes
added
backport release-2.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The windows event log target for Promtail had a typo that led to
EventDatabeing assigned toUserData. This PR fixes this typo.Which issue(s) this PR fixes:
Fixes #6167
Special notes for your reviewer:
First time contributing real code! Please let me know if I missed anything :)
Checklist
CONTRIBUTING.mdguideCHANGELOG.mdupdateddocs/sources/upgrading/_index.md