Retry transient rename failures on Windows

[j178]

Retry Windows rename failures caused by access denial or sharing violations with bounded exponential backoff.

Closes #2755

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-24T03:50:09.219560Z	12f1b62	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Address the synchronous Windows rename and retry removal of stale existing targets.

Review effort: Lite
Findings: None

What changed in this PR

Adds Windows-specific retry handling for transient rename permission failures during repository, hook, and language-tool installation.

Changes:

• Adds centralized exponential-backoff rename retries.
• Applies retries across repository, hook, and language-tool installers.
• Adds Windows-focused tests and Tokio test utilities.

File	Summary
crates/​prek/​src/​store.rs	Retries repository promotion renames.
crates/​prek/​src/​languages/​rust/​rustup.rs	Retries rustup promotion.
crates/​prek/​src/​languages/​ruby/​installer.rs	Retries Ruby promotion.
crates/​prek/​src/​languages/​python/​uv.rs	Retries uv replacement.
crates/​prek/​src/​languages/​node/​installer.rs	Retries Node promotion.
crates/​prek/​src/​languages/​mise/​installer.rs	Retries mise promotion.
crates/​prek/​src/​languages/​golang/​installer.rs	Retries Go promotion.
crates/​prek/​src/​languages/​dotnet/​installer.rs	Retries .NET promotion.
crates/​prek/​src/​languages/​deno/​installer.rs	Retries Deno promotion.
crates/​prek/​src/​languages/​bun/​installer.rs	Retries Bun promotion.
crates/​prek/​src/​fs.rs	Implements rename retry logic and tests.
crates/​prek/​src/​cli/​install.rs	Uses retryable hook renames.
crates/​prek/​Cargo.toml	Enables Tokio test utilities.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.15%. Comparing base (d741340) to head (12f1b62).

Files with missing lines	Patch %	Lines
crates/prek/src/fs.rs	46.15%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
- Coverage   94.18%   94.15%   -0.04%     
==========================================
  Files         142      142              
  Lines       30347    30374      +27     
==========================================
+ Hits        28583    28598      +15     
- Misses       1764     1776      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[prek-ci-bot]

📦 Cargo Bloat Comparison

.text size change: +0.00% (12.7 MiB → 12.7 MiB)

Expand for cargo-bloat output

Head Branch Results

File  .text     Size             Crate Name
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  96.2KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  48.8KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.4%  47.2KiB              prek prek::run::{closure#0}
0.0%   0.3%  42.6KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  40.8KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.3%  40.3KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.2%  29.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.8KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.4KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.4KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.8KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  24.5KiB              prek prek::cli::hook_impl::hook_impl::{closure#0}
4.2%  86.9%  11.0MiB                   And 20331 smaller methods. Use -n N to show more.
4.8% 100.0%  12.7MiB                   .text section size, the file size is 264.6MiB

Base Branch Results

File  .text     Size             Crate Name
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  96.5KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  53.0KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.3%  44.8KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  41.0KiB              prek prek::run::{closure#0}
0.0%   0.3%  39.8KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  37.3KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.2%  29.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.8KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.4KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.7KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  25.1KiB              prek <<prek::config::update::UpdateOptions as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
4.2%  86.9%  11.0MiB                   And 20373 smaller methods. Use -n N to show more.
4.8% 100.0%  12.7MiB                   .text section size, the file size is 265.1MiB

[prek-ci-bot]

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

• OS: Linux 6.17.0-1022-azure
• CPU: 4 cores
• prek version: prek 0.5.3+36 (6252659 2026-09-24)
• Rust version: rustc 1.98.1 (48a229cea 2026-09-01)
• Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.4 ± 0.1	2.2	2.6	1.03 ± 0.04
prek-head --version	2.3 ± 0.1	2.2	2.6	1.00

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	9.2 ± 0.2	8.8	9.7	1.02 ± 0.03
prek-head list	9.0 ± 0.2	8.6	10.1	1.00

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.7 ± 0.1	2.5	3.1	1.04 ± 0.05
prek-head sample-config	2.6 ± 0.1	2.4	2.8	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	35.8 ± 1.6	34.2	40.0	1.05 ± 0.06
prek-head run --all-files	34.1 ± 1.1	32.0	35.9	1.00

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	34.0 ± 0.9	32.1	35.6	1.00
prek-head run --all-files	34.6 ± 1.2	32.6	38.0	1.02 ± 0.05

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	34.2 ± 1.1	31.1	37.1	1.02 ± 0.05
prek-head run --all-files	33.4 ± 1.2	30.7	36.2	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	12.0 ± 0.4	11.5	12.7	1.00
prek-head run trailing-whitespace --all-files	12.1 ± 0.3	11.4	12.6	1.00 ± 0.04

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	10.9 ± 0.5	10.1	11.8	1.05 ± 0.06
prek-head run end-of-file-fixer --all-files	10.4 ± 0.4	9.7	11.4	1.00

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	7.9 ± 0.3	7.4	8.6	1.00
prek-head run check-json --all-files	7.9 ± 0.2	7.5	8.4	1.01 ± 0.05

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	7.8 ± 0.4	7.4	9.0	1.06 ± 0.06
prek-head run check-yaml --all-files	7.4 ± 0.2	7.2	7.9	1.00

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	7.7 ± 0.3	7.3	8.4	1.03 ± 0.05
prek-head run check-toml --all-files	7.5 ± 0.2	7.1	7.9	1.00

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	7.5 ± 0.2	7.1	8.2	1.02 ± 0.05
prek-head run check-xml --all-files	7.3 ± 0.2	7.0	7.8	1.00

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	10.8 ± 0.6	9.7	12.6	1.02 ± 0.07
prek-head run detect-private-key --all-files	10.6 ± 0.4	9.6	11.8	1.00

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	12.3 ± 0.6	11.2	13.4	1.01 ± 0.08
prek-head run fix-byte-order-marker --all-files	12.2 ± 0.7	10.9	13.6	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.9 ± 0.1	4.9	5.0	1.05 ± 0.02
prek-head install-hooks	4.7 ± 0.1	4.6	4.8	1.00

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.8 ± 0.1	4.7	5.0	1.05 ± 0.02
prek-head install-hooks	4.6 ± 0.0	4.6	4.6	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	22.0 ± 0.5	21.3	23.1	1.03 ± 0.03
prek-head run	21.5 ± 0.4	20.9	22.3	1.00

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	5.4 ± 0.1	5.3	5.6	1.07 ± 0.03
prek-head run --files '*.json'	5.1 ± 0.1	4.9	5.3	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	7.1 ± 0.1	6.9	7.3	1.00
prek-head run --dry-run --all-files	7.3 ± 1.2	6.7	12.1	1.03 ± 0.17

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	8.6 ± 0.2	8.4	9.0	1.00
prek-head run check-hooks-apply --all-files	8.9 ± 2.4	7.8	17.5	1.03 ± 0.28

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	8.3 ± 0.2	7.9	8.9	1.04 ± 0.04
prek-head run check-useless-excludes --all-files	8.1 ± 0.1	7.8	8.3	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	7.2 ± 0.1	6.9	7.5	1.00
prek-head run identity --all-files	7.3 ± 0.1	7.1	7.6	1.01 ± 0.03

[Copilot]

Copilot review overview

🟡 Changes recommended

The Windows test has a critical compile issue, and the async retry path can block Tokio's current-thread runtime.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Import Future trait for Windows test poll method · New

[Copilot]

Copilot review overview

🟡 Changes recommended

The unresolved moderate concern about blocking Tokio worker threads should be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Add Windows test coverage for transient rename failures · New

Resolved since last review (1)

• Import Future trait for Windows test poll method