Repository navigation
Share Ruby version queries across hook environments - #2794
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b88e91c27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 94.26% 94.27%
=======================================
Files 142 142
Lines 30743 30831 +88
=======================================
+ Hits 28980 29066 +86
- Misses 1763 1765 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat Comparison
Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 2 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.3 ± 0.1 | 2.1 | 2.7 | 1.00 ± 0.08 |
prek-head --version |
2.2 ± 0.1 | 2.1 | 3.1 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.7 ± 0.4 | 9.2 | 11.5 | 1.02 ± 0.07 |
prek-head list |
9.5 ± 0.5 | 9.0 | 12.7 | 1.00 |
prek validate-config .pre-commit-config.yaml
⏭️ Skipped: .pre-commit-config.yaml not found
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.7 ± 0.3 | 2.6 | 4.4 | 1.01 ± 0.22 |
prek-head sample-config |
2.7 ± 0.5 | 2.5 | 6.3 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
19.6 ± 1.7 | 18.1 | 23.7 | 1.04 ± 0.11 |
prek-head run --all-files |
18.9 ± 1.2 | 17.9 | 21.8 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
19.0 ± 0.6 | 18.0 | 20.2 | 1.03 ± 0.04 |
prek-head run --all-files |
18.5 ± 0.5 | 17.5 | 19.6 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
18.9 ± 1.0 | 17.6 | 23.2 | 1.03 ± 0.07 |
prek-head run --all-files |
18.5 ± 0.8 | 17.3 | 21.5 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
9.0 ± 0.6 | 8.5 | 11.4 | 1.03 ± 0.10 |
prek-head run trailing-whitespace --all-files |
8.8 ± 0.6 | 8.2 | 11.1 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
8.1 ± 0.4 | 7.8 | 9.6 | 1.02 ± 0.07 |
prek-head run end-of-file-fixer --all-files |
7.9 ± 0.3 | 7.6 | 9.0 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
7.2 ± 0.2 | 6.9 | 7.8 | 1.05 ± 0.04 |
prek-head run check-json --all-files |
6.9 ± 0.2 | 6.6 | 7.6 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.4 ± 0.2 | 7.1 | 7.9 | 1.03 ± 0.10 |
prek-head run check-yaml --all-files |
7.2 ± 0.6 | 6.8 | 10.3 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
7.2 ± 0.5 | 6.9 | 9.7 | 1.05 ± 0.08 |
prek-head run check-toml --all-files |
6.9 ± 0.2 | 6.6 | 7.5 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
7.3 ± 0.5 | 7.0 | 9.5 | 1.03 ± 0.12 |
prek-head run check-xml --all-files |
7.1 ± 0.7 | 6.7 | 10.8 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
7.7 ± 0.4 | 7.4 | 9.1 | 1.00 |
prek-head run detect-private-key --all-files |
7.8 ± 1.7 | 7.1 | 16.1 | 1.01 ± 0.23 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
7.8 ± 0.8 | 7.4 | 11.5 | 1.04 ± 0.11 |
prek-head run fix-byte-order-marker --all-files |
7.5 ± 0.3 | 7.2 | 8.5 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
5.1 ± 0.7 | 4.7 | 6.3 | 1.15 ± 0.15 |
prek-head install-hooks |
4.5 ± 0.1 | 4.4 | 4.6 | 1.00 |
✅ Performance improvement for prek install-hooks (cold - no cache): 12.6800% faster
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.6 ± 0.1 | 4.5 | 4.7 | 1.00 |
prek-head install-hooks |
4.9 ± 0.8 | 4.5 | 6.3 | 1.06 ± 0.17 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
19.9 ± 1.0 | 19.0 | 22.9 | 1.60 ± 0.13 |
prek-head run |
12.5 ± 0.8 | 11.9 | 15.5 | 1.00 |
✅ Performance improvement for prek run (staged files only): 37.4900% faster
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
5.7 ± 0.5 | 5.3 | 7.7 | 1.00 ± 0.16 |
prek-head run --files '*.json' |
5.6 ± 0.7 | 5.1 | 8.4 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
7.4 ± 0.7 | 7.1 | 10.0 | 1.04 ± 0.11 |
prek-head run --dry-run --all-files |
7.1 ± 0.4 | 6.8 | 9.0 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
9.1 ± 1.0 | 8.5 | 12.3 | 1.08 ± 0.13 |
prek-head run check-hooks-apply --all-files |
8.4 ± 0.3 | 8.0 | 9.3 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.7 ± 0.4 | 8.3 | 9.6 | 1.03 ± 0.06 |
prek-head run check-useless-excludes --all-files |
8.4 ± 0.3 | 8.0 | 8.9 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
7.4 ± 0.2 | 7.2 | 7.8 | 1.00 |
prek-head run identity --all-files |
7.4 ± 0.7 | 7.0 | 9.4 | 1.00 ± 0.10 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ef3f9ae82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Query each Ruby executable once per run when multiple hook environments share it. Reuse successful results through the existing OnceMap while allowing failed queries to retry.