Repository navigation
Add ppc64le wheel and binary builds - #2809
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2809 +/- ##
==========================================
- Coverage 94.28% 94.28% -0.01%
==========================================
Files 142 142
Lines 30767 30767
==========================================
- Hits 29010 29009 -1
- Misses 1757 1758 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat Comparison
Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.2 ± 0.0 | 2.1 | 2.3 | 1.02 ± 0.04 |
prek-head --version |
2.1 ± 0.1 | 2.0 | 2.3 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.2 ± 0.4 | 8.9 | 11.6 | 1.00 |
prek-head list |
9.2 ± 0.5 | 8.9 | 12.2 | 1.00 ± 0.07 |
prek validate-config .pre-commit-config.yaml
⏭️ Skipped: .pre-commit-config.yaml not found
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.6 ± 0.4 | 2.4 | 5.3 | 1.02 ± 0.17 |
prek-head sample-config |
2.6 ± 0.2 | 2.4 | 3.6 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
17.3 ± 0.7 | 16.8 | 19.4 | 1.01 ± 0.05 |
prek-head run --all-files |
17.2 ± 0.5 | 16.7 | 18.4 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
17.3 ± 0.4 | 16.9 | 18.6 | 1.01 ± 0.03 |
prek-head run --all-files |
17.2 ± 0.3 | 16.5 | 17.7 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
17.2 ± 0.4 | 16.4 | 18.9 | 1.00 |
prek-head run --all-files |
17.3 ± 0.5 | 16.3 | 18.8 | 1.00 ± 0.04 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
8.4 ± 0.4 | 8.0 | 10.1 | 1.00 |
prek-head run trailing-whitespace --all-files |
8.5 ± 0.4 | 8.0 | 9.6 | 1.01 ± 0.06 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
7.6 ± 0.2 | 7.4 | 8.4 | 1.00 |
prek-head run end-of-file-fixer --all-files |
7.6 ± 0.2 | 7.4 | 8.3 | 1.00 ± 0.04 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
6.8 ± 0.5 | 6.5 | 9.1 | 1.01 ± 0.09 |
prek-head run check-json --all-files |
6.8 ± 0.3 | 6.6 | 8.3 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.0 ± 0.1 | 6.8 | 7.2 | 1.00 |
prek-head run check-yaml --all-files |
7.0 ± 0.3 | 6.8 | 8.0 | 1.00 ± 0.05 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
6.8 ± 0.2 | 6.6 | 8.0 | 1.00 |
prek-head run check-toml --all-files |
7.2 ± 0.4 | 6.6 | 8.5 | 1.07 ± 0.08 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
6.9 ± 0.2 | 6.6 | 7.6 | 1.00 |
prek-head run check-xml --all-files |
7.0 ± 0.4 | 6.6 | 8.6 | 1.01 ± 0.07 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
7.3 ± 0.4 | 7.0 | 8.8 | 1.00 ± 0.07 |
prek-head run detect-private-key --all-files |
7.3 ± 0.3 | 7.0 | 8.9 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
7.5 ± 0.6 | 7.2 | 10.4 | 1.01 ± 0.08 |
prek-head run fix-byte-order-marker --all-files |
7.4 ± 0.1 | 7.2 | 7.7 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.6 ± 0.2 | 4.4 | 4.9 | 1.00 |
prek-head install-hooks |
4.7 ± 0.3 | 4.5 | 5.3 | 1.04 ± 0.08 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.6 ± 0.1 | 4.5 | 4.6 | 1.00 |
prek-head install-hooks |
4.6 ± 0.1 | 4.5 | 4.7 | 1.01 ± 0.02 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
11.6 ± 0.1 | 11.4 | 11.9 | 1.00 |
prek-head run |
11.6 ± 0.1 | 11.5 | 11.9 | 1.00 ± 0.02 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
5.5 ± 1.0 | 5.1 | 9.8 | 1.05 ± 0.19 |
prek-head run --files '*.json' |
5.3 ± 0.1 | 5.1 | 5.4 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
6.9 ± 0.1 | 6.8 | 7.0 | 1.00 |
prek-head run --dry-run --all-files |
7.0 ± 0.2 | 6.7 | 7.6 | 1.00 ± 0.03 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
8.4 ± 0.4 | 8.1 | 9.8 | 1.00 |
prek-head run check-hooks-apply --all-files |
8.5 ± 0.2 | 8.2 | 8.8 | 1.01 ± 0.05 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.2 ± 0.1 | 8.1 | 8.4 | 1.00 |
prek-head run check-useless-excludes --all-files |
8.4 ± 0.3 | 8.0 | 8.8 | 1.02 ± 0.04 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
7.3 ± 0.2 | 7.0 | 7.7 | 1.02 ± 0.03 |
prek-head run identity --all-files |
7.2 ± 0.1 | 7.0 | 7.4 | 1.00 |
|
Thanks! |
Build binary wheels for ppc64le, the architecture of "modern" IBM PowerPC machines (i.e., not embedded devices or old Macs, but modern Power servers).
Motivation: We have large compute grids with ppc64le machines and would like prek there.
Testing:
dry-runrelease build in my fork: https://github.com/imphil/prek/actions/runs/36718512604Builds in GitHub actions are roughly as fast as the aarch64 builds (5m 40s for linux-ppc64le in my testing vs 5m 42s for linux-arm)