Skip to content

Reincorporate user settings (FZF_ALT_C_COMMAND, etc.) in shell-integration behavior#4400

Closed
clarity20 wants to merge 1 commit into
junegunn:masterfrom
clarity20:shell_integration
Closed

Reincorporate user settings (FZF_ALT_C_COMMAND, etc.) in shell-integration behavior#4400
clarity20 wants to merge 1 commit into
junegunn:masterfrom
clarity20:shell_integration

Conversation

@clarity20

Copy link
Copy Markdown

The fzf keyboard shortcuts (ALT-C, etc.) were not using my FZF_* environment settings until I made the following code change. This change ensures that once the env is parsed, the arguments specified in the env variables are forwarded to the winpty child process along with the commandline arguments.

@junegunn

junegunn commented May 27, 2025

Copy link
Copy Markdown
Owner

winpty doesn't pass down the exported variables? Is it a known limitation of winpty?

@junegunn

Copy link
Copy Markdown
Owner

I believe this was a bug introduced by aefb9a5, and 0a8ff78 should fix it.

Please test it and let me know if it works for you.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 1, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [junegunn/fzf](https://github.com/junegunn/fzf) | patch | `v0.65.1` -> `v0.65.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>junegunn/fzf (junegunn/fzf)</summary>

### [`v0.65.2`](https://github.com/junegunn/fzf/releases/tag/v0.65.2): 0.65.2

[Compare Source](junegunn/fzf@v0.65.1...v0.65.2)

- Bug fixes and improvements
  - Fix incorrect truncation of `--info-command` with `--info=inline-right` ([#&#8203;4479](junegunn/fzf#4479))
  - \[install] Support old uname in macOS ([#&#8203;4492](junegunn/fzf#4492))
  - \[bash 3] Fix `CTRL-T` and `ALT-C` to preserve the last yank ([#&#8203;4496](junegunn/fzf#4496))
  - Do not unset `FZF_DEFAULT_*` variables when using winpty ([#&#8203;4497](junegunn/fzf#4497)) ([#&#8203;4400](junegunn/fzf#4400))
  - Fix rendering of items with tabs when using a non-default ellipsis ([#&#8203;4505](junegunn/fzf#4505))
- **This is the final release to support Windows 7.**
  - Future versions will be built with the latest Go toolchain, which has dropped support for Windows 7.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MC4wIiwidXBkYXRlZEluVmVyIjoiNDEuOTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants