Fix confusing terminal output when using ServerApp.ip=0.0.0.0 - #1643
Merged
Conversation
Contributor
|
This PR fixes the |
Pointed out in jupyterlab/jupyterlab#15520, When using --ip=:: or 0.0.0.0, terminal displays: ``` Or copy and paste one of these URLs: http://xxx.local:8888/lab?token=xxx http://127.0.0.1:8888/lab?token=xxx ``` Which makes it look like it does not listen on all interfaces, but in fact it does. Fixed with jupyter-server#743 in mind to avoid a regression in k8s.
Instead, use a text hint. Example : ``` Or copy and paste one of these URLs: http://mycomputer.local:8888/?token=... http://127.0.0.1:8888/?token=... The server is listening on all interfaces, so any hostname or IP of this machine will work. ```
Collaborator
Author
|
Thank you for reviewing. Fixed in b62505c The output is now |
Contributor
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointed out in jupyterlab/jupyterlab#15520,
When using
--ip=::or0.0.0.0, terminal displays:Which makes it look like it does not listen on all interfaces, but in fact it does.
After this fix:
Fixed with #743 in mind to avoid a regression in k8s.
Steps to test
jupyter server --ip 0.0.0.0And check for no regressions on
jupyter server --ip "",jupyter server --ip 127.0.0.1,jupyter server --ip <arbitrary ip>These are unit-tested too.
AI disclosure
Claude code, only to dig up the history of previous changes to avoid a regression.