Skip to content

remove session error dialog redundant error message to avoid repeated display#10810

Merged
blink1073 merged 1 commit into
jupyterlab:masterfrom
franckchen:sessionErrorDialogMessage
Aug 12, 2021
Merged

remove session error dialog redundant error message to avoid repeated display#10810
blink1073 merged 1 commit into
jupyterlab:masterfrom
franckchen:sessionErrorDialogMessage

Conversation

@franckchen

@franckchen franckchen commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

References

Fixes #10809

Code changes

User-facing changes

Backwards-incompatible changes

@welcome

welcome Bot commented Aug 12, 2021

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-dev-mode

Copy link
Copy Markdown

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @franckchen.

Could you update the PR description to add a reference to the associated issue (something like Fixes #<issue_id>). This will create link in GitHub and automatically close the issue when the PR good merged.

@franckchen

Copy link
Copy Markdown
Contributor Author

Thanks @franckchen.

Could you update the PR description to add a reference to the associated issue (something like Fixes #<issue_id>). This will create link in GitHub and automatically close the issue when the PR good merged.

Ok. Thanks. I forgot. Now I added and I also modified my commit message.

@fcollonval fcollonval left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @franckchen for the quick update.

This looks good to me.

@fcollonval

Copy link
Copy Markdown
Member

We have some trouble with the CI for now. So I'll let this one open to give it a chance when those troubles are fixed.

@franckchen franckchen requested a review from fcollonval August 12, 2021 08:07
@blink1073

Copy link
Copy Markdown
Contributor

Kicking CI

@blink1073 blink1073 closed this Aug 12, 2021
@blink1073 blink1073 reopened this Aug 12, 2021
@blink1073 blink1073 added the bug label Aug 12, 2021
@blink1073 blink1073 added this to the 3.1.x milestone Aug 12, 2021
@blink1073

Copy link
Copy Markdown
Contributor

Kicking CI

@blink1073 blink1073 closed this Aug 12, 2021
@blink1073 blink1073 reopened this Aug 12, 2021
@blink1073 blink1073 merged commit 2d6c66a into jupyterlab:master Aug 12, 2021
@welcome

welcome Bot commented Aug 12, 2021

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073

Copy link
Copy Markdown
Contributor

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 12, 2021
blink1073 pushed a commit that referenced this pull request Aug 12, 2021
…ge to avoid repeated display (#10822)

Co-authored-by: Franck Chan <franckchen@foxmail.com>
@github-actions github-actions Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Feb 9, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug pkg:apputils status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session context error dialog print error message twice

3 participants