Skip to content

Check i18n will pass on zeroed patch pre-release version#11214

Merged
blink1073 merged 1 commit into
jupyterlab:masterfrom
fcollonval:fix/skip-i18n-X.Y.0-pre-release
Oct 5, 2021
Merged

Check i18n will pass on zeroed patch pre-release version#11214
blink1073 merged 1 commit into
jupyterlab:masterfrom
fcollonval:fix/skip-i18n-X.Y.0-pre-release

Conversation

@fcollonval

Copy link
Copy Markdown
Member

References

Fixes #11213

Code changes

Skip raising failure for check i18n if the python package version is a pre-release of X.Y.0 version

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@blink1073 blink1073 added this to the 3.2.x milestone Oct 5, 2021
@github-actions

github-actions Bot commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 7270 <- [8551 - 8777 - 9352] -> 9903 4387 <- [4720 - 4761 - 4843] -> 5079
expected 6938 <- [7584 - 7618 - 7760] -> 8204 3461 <- [3524 - 3534 - 3590] -> 4136
switch-from
chromium
actual 516 <- [524 - 540 - 551] -> 576 344 <- [358 - 365 - 381] -> 390
expected 464 <- [480 - 489 - 499] -> 789 310 <- [338 - 344 - 352] -> 370
switch-to
chromium
actual 1873 <- [1911 - 1921 - 1970] -> 2076 1624 <- [1679 - 1692 - 1717] -> 1797
expected 1706 <- [1730 - 1764 - 1814] -> 2015 1541 <- [1549 - 1562 - 1574] -> 1608
close
chromium
actual 7286 <- [17745 - 19728 - 21419] -> 22560 4297 <- [4386 - 4884 - 5189] -> 5388
expected 5176 <- [5770 - 10533 - 14493] -> 18824 3325 <- [3691 - 3890 - 3939] -> 4073

❗ Test metadata have changed
--- /dev/fd/63	2021-10-05 11:36:54.388954218 +0000
+++ /dev/fd/62	2021-10-05 11:36:54.388954218 +0000
@@ -8,33 +8,33 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v3",
+      "brand": "Xeon® Platinum 8171M",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 524288,
-        "l3": 31457280
+        "l2": 2097152,
+        "l3": 36700160
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "63",
+      "model": "85",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.4,
+      "speed": 2.6,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "2",
+      "stepping": "4",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291699200
+      "total": 7291695104
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "487dcaac68944409a00596acdb9a6fc0",
+      "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
       "servicepack": "",
       "uefi": false
     }

@blink1073 blink1073 merged commit 663b01a into jupyterlab:master Oct 5, 2021
@blink1073

Copy link
Copy Markdown
Contributor

@meeseeksdev please backport to 3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 5, 2021
blink1073 pushed a commit that referenced this pull request Oct 5, 2021
…version (#11217)

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@blink1073

Copy link
Copy Markdown
Contributor

@meeseeksdev please backport to 3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 5, 2021
blink1073 pushed a commit that referenced this pull request Oct 5, 2021
…version (#11231)

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@fcollonval fcollonval deleted the fix/skip-i18n-X.Y.0-pre-release branch October 6, 2021 05:46
@github-actions github-actions Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Apr 5, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check i18n should pass on pre-release of X.Y.0 version

2 participants