Skip to content

Changes Vega class name to match source code#12378

Merged
fcollonval merged 1 commit into
jupyterlab:masterfrom
JasonWeill:vega5-css
Apr 9, 2022
Merged

Changes Vega class name to match source code#12378
fcollonval merged 1 commit into
jupyterlab:masterfrom
JasonWeill:vega5-css

Conversation

@JasonWeill

Copy link
Copy Markdown
Contributor

References

Fixes #12377

Code changes

Changes CSS class name in source code.

User-facing changes

Screen shot before changing the style sheet
image

Screen shot after changing the style sheet
image

Note that Firefox disregards the margin-left and margin-right rules because it doesn't apply them to elements with style display: table-cell, like this one.

Backwards-incompatible changes

None.

@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions Bot added Design System CSS pkg:vega tag:CSS For general CSS related issues and pecadilloes labels Apr 7, 2022
@fcollonval fcollonval added this to the 3.3.x milestone Apr 9, 2022

@fcollonval fcollonval left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit d749628 into jupyterlab:master Apr 9, 2022
@fcollonval

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 9, 2022
fcollonval pushed a commit that referenced this pull request Apr 9, 2022
)

Co-authored-by: Jason Weill <93281816+jweill-aws@users.noreply.github.com>
@github-actions

github-actions Bot commented Apr 9, 2022

Copy link
Copy Markdown
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 4470 <- [4593 - 4679 - 4751] -> 5056 3082 <- [3237 - 3288 - 3347] -> 3498
expected 4403 <- [4547 - 4626 - 4702] -> 5064 3138 <- [3241 - 3312 - 3370] -> 3521
Mean relative change 0.9% ± 0.7% -0.6% ± 0.7%
switch-from
chromium
actual 762 <- [821 - 841 - 859] -> 1104 527 <- [554 - 570 - 584] -> 1194
expected 756 <- [812 - 838 - 860] -> 1071 524 <- [557 - 571 - 585] -> 1216
Mean relative change 0.9% ± 1.6% 1.1% ± 4.6%
switch-to
chromium
actual 382 <- [450 - 462 - 474] -> 597 293 <- [331 - 341 - 353] -> 389
expected 378 <- [446 - 459 - 469] -> 530 291 <- [330 - 340 - 351] -> 382
Mean relative change 0.7% ± 1.7% 0.9% ± 1.5%
close
chromium
actual 645 <- [1133 - 1155 - 1177] -> 1309 536 <- [566 - 579 - 594] -> 651
expected 635 <- [1128 - 1147 - 1172] -> 1244 540 <- [567 - 579 - 592] -> 622
Mean relative change 0.1% ± 3.7% 0.3% ± 0.9%

Changes are computed with expected as reference.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Design System CSS pkg:vega tag:CSS For general CSS related issues and pecadilloes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vega style sheet uses different class name than Vega extension does

2 participants