Add a setter to TagWidget's parent#13111
Merged
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
brichet
changed the title
brichet
force-pushed
the
fix/cellTag_insert
branch
from
762a692 to
4d30bc0
Compare
brichet
force-pushed
the
fix/cellTag_insert
branch
from
4d30bc0 to
1b4d45a
Compare
fcollonval
approved these changes
Sep 26, 2022
fcollonval
left a comment
fcollonval
left a comment
Member
There was a problem hiding this comment.
Thanks @brichet
CI failures are not related.
|
Congrats on your first merged pull request in this project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A getter has been added to the
TagWidget's parent attribute inv4.0.0a28, without setter (which should rely to its parent class).It look like Typescript does not allow overriding the getter without the setter and vice versa.
At the end, it is not possible to add a new tag to a cell :
Code changes
Add a setter to
TagWidget's parent attribute.Backwards-incompatible changes
None