Backporting IUser/Collaboration PRs#13242
Conversation
|
Thanks for making a pull request to jupyterlab! |
github-actions
Bot
added
Design System CSS
documentation
pkg:debugger
pkg:docmanager
pkg:docprovider
pkg:docregistry
pkg:shared-models
pkg:themes
pkg:ui-components
tag:CSS
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
martinRenou
force-pushed
the
collaboration
branch
from
7ae4a18 to
9f06adf
Compare
|
It's technically working. It might be missing some CSS imports somewhere though.
|
|
Probably need #12586 or related to align the user menu to the right. Although this might be breaking for some folks / extensions already using the top area in 3.x. |
|
You're commenting at the right time, I was looking for this! Thanks. Do you think there is a way to do this in a non-breaking way? |
|
Probably the only "breaking" change would be visually with the addition of the spacer widget in the top area. This might affect extensions that add widgets to the top area, similar to https://github.com/jtpio/jupyterlab-system-monitor. Not sure we should do anything clever to handle this, or just document this change in a Another option would be to leave the user menu indicator on the left hand side as is and not backport #12586. |
…b#11443) * Adds a new package for the user information * Read user info from IUser when opening a new document * Adds a user menu * Remove anonymous names from docprovider and runs integrity and eslint:typed * Small fix menu * Rename tokens ID to match the token name * Adds new tokens to the documentation * Review * Remove components * Adds tests * Create the user menu only if collaborative flag is true * Revert changes on UI tests * Adds tests to the user menu * Review * Integrity * Small issue * Store user in local storage, remove StateDB and run integrity * Remove 'id', 'name', and adds 'givenName', 'familyName', and 'initials' * Update packages as part of the rebase * Removes role, and solves an issue with names on the editor * Change tests user package * Makes colors private, removes public methods from IUserMenu * Package integrity updates * Tag ICurrentUser token and interface as experimental
…n, and solve issue shared-model test (jupyterlab#11605)
* Adds the list of colors for collaborators to themes * Change colors * Update palette dark theme * Fix mistake from the rebase * Change name variables
* Adds name and displayName to the user * Adds initials to the url * solves a mistake in URL parameters
* Add left panel for RTC Co-authored-by: martinRenou <martin.renou@gmail.com> Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> Co-authored-by: "Afshin T. Darian" <git@darian.email> * Remove sidepanel * Remove uneeded token * Remove custom rtc panel CSS Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Add translation * Regenerate yarn.lock and run prettier * Re-generate yarn.lock Co-authored-by: Carlos Herrero <carlosherrerocontact@gmail.com> Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> Co-authored-by: "Afshin T. Darian" <git@darian.email> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> Co-authored-by: foo <foo@bar.com>
martinRenou
force-pushed
the
collaboration
branch
from
c0fd47a to
d1e4ec6
Compare
|
CI failing with |
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @martinRenou
I have some suggestion
Probably we can publish the package from this branch as is to make the CI pass. |
martinRenou
force-pushed
the
collaboration
branch
from
50ff2ec to
492dd71
Compare
|
Just published |
|
Thanks Marin for doing all these backports! |
6 participants
References
Backports of all PRs concerning real-time collaboration UI changes (left panel, top menu) #11443 #11605 #11703 #11774 #12046 #12175 #12548 #12095