Skip to content

Export return type of a public method#13354

Merged
fcollonval merged 2 commits into
jupyterlab:masterfrom
fcollonval:fix/export-returned-private-interface
Nov 2, 2022
Merged

Export return type of a public method#13354
fcollonval merged 2 commits into
jupyterlab:masterfrom
fcollonval:fix/export-returned-private-interface

Conversation

@fcollonval

Copy link
Copy Markdown
Member

References

Seen when working on #13337

Code changes

export IExecutionState as it is returned by a public method of ExecutionIndicator.Model that itself is publicly available as it extends VDomModel

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval merged commit d3699dd into jupyterlab:master Nov 2, 2022
@fcollonval fcollonval deleted the fix/export-returned-private-interface branch November 2, 2022 08:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant