Add announcements#13365
Merged
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Nov 3, 2022
github-actions
Bot
added
Design System CSS
documentation
pkg:debugger
pkg:extensionmanager
pkg:statusbar
tag:CSS
jasongrout
reviewed
Nov 9, 2022
jasongrout
reviewed
Nov 9, 2022
jasongrout
reviewed
Nov 9, 2022
fcollonval
force-pushed
the
ft/announcements
branch
from
56099c8 to
84ca78e
Compare
jtpio
reviewed
Nov 14, 2022
jtpio
reviewed
Nov 14, 2022
Member
|
Thanks @fcollonval. Mind sharing a screencast of what the UX/UI looks like with this PR? |
jtpio
reviewed
Nov 14, 2022
jtpio
reviewed
Nov 14, 2022
jtpio
reviewed
Nov 14, 2022
fcollonval
force-pushed
the
ft/announcements
branch
from
ebd1354 to
7351d5f
Compare
Remove following the rebase
Member
Author
|
js-services failure is not related |
Member
Author
|
@jtpio would you mind having a second look please? |
jtpio
reviewed
Nov 17, 2022
jtpio
left a comment
jtpio
left a comment
Member
There was a problem hiding this comment.
Thanks @fcollonval.
I left a couple of inline comments (typos, questions) but otherwise it looks good.
Also checked on the Binder for this PR 👍
Member
Is that really the case? According to the logs there is at least one link failing which is probably not going to work afterwards? (generic jupyterlab.github.io)
|
fcollonval
commented
Nov 17, 2022
fcollonval
commented
Nov 17, 2022
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Member
Author
|
CI failures are not related |
Member
Author
|
@meeseeksdev please backport to 3.6.x |
|
Oops, something went wrong applying the patch ... Please have a look at my logs. |
Member
|
@fcollonval mind updating the mocks / tests as per this comment for consistency? #13365 (comment) |
fcollonval
added a commit
to fcollonval/jupyterlab
that referenced
this pull request
Nov 18, 2022
* Add backend * Request announcements from frontend * Make announcement opt-in * Add privacy policies * Minor style improvement on extensions pagination * Fix highlighting the icon when the notification center is opened * Add `Disable` button as alternative to `Agree` * Add Python tests * Use enum for settting * Apply review suggestion * Fix default update checker * Apply suggestions from code review Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> * Fix python test * Add integration tests * Fix doc error * Fix eslint * Fix integration tests * Fix Python * Fix Python test * Fix mocking settings in integration tests * Add documentation * Lint * Update Playwright Snapshots * Add missing `Type` import Remove following the rebase * Apply suggestions from code review Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> * Ignore base website mentioned in privacy policy * Fix extensions manager integration test * Update documentation snapshot Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 3e8f4e5)
fcollonval
added a commit
to fcollonval/jupyterlab
that referenced
this pull request
Nov 18, 2022
3 tasks
fcollonval
added a commit
that referenced
this pull request
Nov 18, 2022
* Use default URL in test mock-up Follow-up of #13365 * Update the privacy policy last modification date This is needed as that policy will change when JupyterLab 4 is released (new extensions manager)
fcollonval
added a commit
that referenced
this pull request
Nov 21, 2022
* Backport #13365 on branch 3.6.x (Add announcements) * Fix access to translator * Fix doc * Update Playwright Snapshots * Backport style correct on the link style * Update Playwright Snapshots * Ignore NPM public registry link Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fix #13110
Code changes
Add a new plugin to fetch announcements from Atom feed and update check.
User-facing changes
Add notifications at start up from announcements feed.
Backwards-incompatible changes
N/A