Set font families that were not specified.#13533
Merged
fcollonval merged 5 commits intoDec 13, 2022
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
github-actions
Bot
added
Design System CSS
pkg:ui-components
tag:CSS
fcollonval
reviewed
Dec 5, 2022
fcollonval
force-pushed
the
set_non_specified_font_families
branch
from
af5cac9 to
b2c2bac
Compare
Member
|
bot please update snapshots |
Contributor
|
Documentation snapshots updated. |
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fcollonval
force-pushed
the
set_non_specified_font_families
branch
from
7240e40 to
310ad11
Compare
Member
|
bot please update snapshots |
Contributor
|
Documentation snapshots updated. |
Member
|
bot please update documentation snapshots |
Contributor
|
Galata snapshots updated. |
Contributor
|
Documentation snapshots updated. |
fcollonval
force-pushed
the
set_non_specified_font_families
branch
from
394dd4c to
7fb3423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on a theme editor extension, there were only there 3 texts items ("Code" in notebook toolbar, the name of the kernel and the switch label) that were not following the selected ui-font family.
References
Code changes
Add font families in packages/ui-components/style in switch.css, base.css and toolbar.css
User-facing changes
Backwards-incompatible changes