Skip to content

Galata config helper should not set dev_mode#14012

Merged
jtpio merged 1 commit into
jupyterlab:masterfrom
fcollonval:fix/galata-server-config-helper
Feb 15, 2023
Merged

Galata config helper should not set dev_mode#14012
jtpio merged 1 commit into
jupyterlab:masterfrom
fcollonval:fix/galata-server-config-helper

Conversation

@fcollonval

@fcollonval fcollonval commented Feb 15, 2023

Copy link
Copy Markdown
Member

References

Follow-up of jupyterlab/extension-cookiecutter-ts#287

Code changes

The server config helper should not set dev_mode

User-facing changes

Testing with galata starting the server with the helper method should work.

Backwards-incompatible changes

None

@jupyterlab-probot

jupyterlab-probot Bot commented Feb 15, 2023

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Feb 15, 2023
@fcollonval fcollonval added this to the 4.0.0 milestone Feb 15, 2023
jtpio
jtpio approved these changes Feb 15, 2023
View reviewed changes

@jtpio jtpio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 642c96c into jupyterlab:master Feb 15, 2023
@fcollonval fcollonval deleted the fix/galata-server-config-helper branch February 15, 2023 18:00
@github-actions

github-actions Bot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 490 <- [519 - 532 - 545] -> 589 959 <- [1049 - 1074 - 1102] -> 1257
expected 490 <- [519 - 533 - 551] -> 727 988 <- [1041 - 1065 - 1091] -> 1216
Mean relative change -1.3% ± 1.5% 0.4% ± 1.3%
switch-from
chromium
actual 625 <- [696 - 710 - 725] -> 824 276 <- [363 - 380 - 402] -> 496
expected 650 <- [699 - 717 - 725] -> 951 284 <- [361 - 377 - 404] -> 644
Mean relative change -0.9% ± 1.4% -0.4% ± 3.0%
switch-to
chromium
actual 1109 <- [1295 - 1337 - 1374] -> 1546 795 <- [922 - 945 - 972] -> 1039
expected 1120 <- [1321 - 1350 - 1380] -> 1491 798 <- [903 - 928 - 950] -> 1029
Mean relative change -0.4% ± 1.3% 2.0% ± 1.2%
close
chromium
actual 134 <- [142 - 145 - 150] -> 160 176 <- [196 - 208 - 215] -> 301
expected 127 <- [141 - 144 - 150] -> 201 186 <- [202 - 209 - 217] -> 266
Mean relative change 0.1% ± 1.4% -1.5% ± 2.1%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: +145 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentString 1 +82 B
Detached Text 1 +61 B
ResizeHandle 1 +47 B
Set 1 +133 B
Signal 1 +38 B
UndoManager 1 +1.38 kB
YArray 1 +164 B
YText 1 +314 B
Detached DOMStringMap 2 +84 B
Detached V8EventHandlerNonNull 2 +80 B
StackItem 2 +952 B
YMap 2 +464 B
ContentType 4 +273 B
DeleteItem 4 +80 B
DeleteSet 4 +720 B
StyleModule 4 +128 B
ContentAny 5 +254 B
Detached HTMLCollection 6 +544 B
EventHandler 8 +256 B
ID 10 +320 B
Item 10 +1.43 kB
Map 11 +1.73 kB
DOMRectReadOnly 12 +672 B
Detached Attr 13 +936 B
Detached DOMTokenList 13 +780 B
Detached HTMLDivElement 13 +44.9 kB
Object 38 +62.2 kB
Detached V8EventListener 262 +21.9 kB
(closure) 264 +25.8 kB
Detached EventListener 264 +41 kB
Detached InternalNode 318 +43.4 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +4 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +1 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +1 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Create a markdown cell Memory change: +179 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +450 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +9 B
AttachmentsResolver 1 +15 B
ContentString 1 +79 B
Debouncer 1 +3.47 kB
Detached HTMLAnchorElement 1 +288 B
Detached HTMLButtonElement 1 +5.24 kB
Detached HTMLHeadingElement 1 +920 B
Error 1 +3.03 kB
MarkdownCell 1 +4.69 kB
MarkdownCellModel 1 +381 B
Poll 1 +3.45 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +65 B
Transaction 1 +876 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YMarkdownCell 1 +137 B
Detached CSSStyleDeclaration 2 +112 B
Detached HTMLElement 2 +288 B
Detached V8EventHandlerNonNull 2 +4.99 kB
ObservableMap 2 +256 B
Promise 2 +3.07 kB
PromiseDelegate 2 +3.29 kB
StackItem 2 +932 B
UndoManager 2 +1.79 kB
YText 2 +534 B
DeleteItem 3 +60 B
Detached DOMStringMap 3 +120 B
DeleteSet 4 +700 B
YMap 4 +872 B
ContentAny 5 +524 B
ContentType 7 +718 B
Detached Text 7 +448 B
Set 8 +733 B
StyleModule 8 +256 B
Detached HTMLDivElement 10 +30.1 kB
Detached DOMTokenList 13 +752 B
ID 13 +416 B
Item 13 +2.4 kB
EventHandler 14 +448 B
Detached HTMLCollection 17 +1.68 kB
Signal 20 +342 B
Map 23 +3.36 kB
Object 52 +82.5 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.4 kB
(closure) 151 +38.4 kB
Detached InternalNode 162 +28 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [20799f70-0419-4bee-8611-05129346fd6c, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2289:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +8 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Create a raw cell Memory change: +137 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentString 1 +79 B
Detached CSSStyleDeclaration 1 +56 B
Detached V8EventHandlerNonNull 1 +40 B
YArray 1 +164 B
Detached DOMStringMap 2 +84 B
Set 2 +277 B
StackItem 2 +932 B
UndoManager 2 +1.79 kB
YText 2 +534 B
DeleteItem 3 +60 B
DeleteSet 4 +700 B
YMap 4 +872 B
ContentAny 5 +454 B
Detached HTMLCollection 5 +452 B
ContentType 7 +718 B
StyleModule 7 +224 B
Detached DOMTokenList 9 +524 B
Detached HTMLDivElement 9 +22.5 kB
ID 13 +416 B
Item 13 +2.33 kB
EventHandler 14 +448 B
Map 15 +2.53 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +19.8 kB
Detached InternalNode 151 +21.5 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [10e3a78a-9ce0-4ac5-98ac-50b61e48a3fe, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2289:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.b4a60ac865fcead2decf.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +7 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5049:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
Set +2 Set((anonymous function), ...) 
                 webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                            
Doc.on           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManager  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/y-sync.js:11:0                                
                 webpack://jupyterlab/node_modules/y-codemirror.next/src/index.js:20:0                                 
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:947:16                                         
                 webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27                                         
                 webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11                                         
                 webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42
✔ Adding a cell (250623ms) - Drag and drop a cell

File editor memory leaks

Create a file Memory change: +196 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.26 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.4 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +138 B
LabIcon 2 +1.06 kB
Detached CSSStyleDeclaration 3 +216 B
Detached HTMLLIElement 3 +4.86 kB
Detached NodeList 3 +188 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +106 B
Detached SVGGElement 4 +2.94 kB
StyleModule 4 +128 B
VirtualElement 4 +2.13 kB
Detached HTMLSpanElement 5 +1.98 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.77 kB
Detached SVGSVGElement 5 +7.88 kB
Detached DOMStringMap 7 +360 B
Detached SVGAnimatedNumber 7 +448 B
Detached Text 9 +608 B
Detached Attr 10 +720 B
Detached DOMTokenList 13 +764 B
Detached HTMLCollection 13 +1.32 kB
Detached HTMLDivElement 15 +32.4 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +20 kB

Leaking collections:

Type Change Preview Size increased at
Array +4 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:73:11          
  webpack://jupyterlab/packages/fileeditor/src/widget.ts:219:13          
  webpack://jupyterlab/packages/codeeditor/src/widget.ts:40:42

Notebook memory leaks

Create a notebook Memory change: +10.7 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +3.21 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +55 B
Detached HTMLButtonElement 2 +23.5 kB
Detached SVGCircleElement 2 +1.1 kB
LabIcon 2 +72 B
Detached CSSStyleDeclaration 3 +172 B
Detached HTMLLIElement 3 +6.58 kB
Detached NodeList 3 +196 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +110 B
VirtualElement 4 +1.19 kB
Detached HTMLSpanElement 5 +2.8 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.34 kB
Detached SVGGElement 6 +4.9 kB
Detached SVGPathElement 7 +2.47 kB
StyleModule 8 +789 B
Detached SVGAnimatedNumber 9 +576 B
Detached Text 9 +872 B
Detached Attr 10 +720 B
Detached HTMLCollection 13 +1.35 kB
Detached DOMTokenList 14 +776 B
Detached HTMLDivElement 15 +33.8 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +32 kB

Leaking collections:

Type Change Preview Size increased at
Array +8 [StyleModule, ...] 
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:115:0     
  webpack://jupyterlab/node_modules/style-mod/src/style-mod.js:79:0      
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6649:8
  webpack://jupyterlab/node_modules/@codemirror/view/dist/index.js:6300:0
  webpack://jupyterlab/packages/codemirror/src/editor.ts:954:17          
  webpack://jupyterlab/packages/codemirror/src/editor.ts:163:27          
  webpack://jupyterlab/packages/codemirror/src/factory.ts:61:11          
  webpack://jupyterlab/packages/codeeditor/src/jsoneditor.ts:83:26       
  webpack://jupyterlab/packages/notebook/src/notebooktools.ts:676:21
✔ Opening a notebook (79841ms)

2 passing (7m)
1 pending
1 failing

   Opening a text file:

  AssertionError: expected true to equal false
  + expected - actual

  -true
  +false
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:35:12
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/file-editor.test.mjs:6:5)

@fcollonval fcollonval mentioned this pull request Mar 31, 2023
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels

bug tag:Testing

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio