Adds this context when calling ICompletionProvider.modelFactory#14812
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Jul 12, 2023
krassowski
left a comment
krassowski
left a comment
Member
There was a problem hiding this comment.
Worth modifying tests to test this?
Member
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 18, 2023
…ionProvider.modelFactory
fcollonval
pushed a commit
that referenced
this pull request
Jul 19, 2023
…r.modelFactory (#14843) Co-authored-by: Carlos Herrero <26092748+hbcarlos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #14805
Code changes
See #14805
User-facing changes
N/A
Backwards-incompatible changes
N/A