Skip to content

Fix toggling extension at system level#16241

Merged
jtpio merged 7 commits into
jupyterlab:mainfrom
krassowski:fix-toggling
Apr 26, 2024
Merged

Fix toggling extension at system level#16241
jtpio merged 7 commits into
jupyterlab:mainfrom
krassowski:fix-toggling

Conversation

@krassowski

@krassowski krassowski commented Apr 25, 2024

Copy link
Copy Markdown
Member

References

Fixes #16240

Code changes

  • Add a test for extension toggling the system level
  • Ensure _is_extension_locked works for system level

User-facing changes

Toggling at system level works.

Backwards-incompatible changes

None

@krassowski krassowski added the bug label Apr 25, 2024
@krassowski krassowski added this to the 4.1.x milestone Apr 25, 2024
@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 099739a into jupyterlab:main Apr 26, 2024
@jtpio

jtpio commented Apr 26, 2024

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 4.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2024
krassowski added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
* Add a test for extension toggling the system level

* Do not check higher levels for `system` level

* Add sudo

* Fix test

* Debug CI

* Try with a different extension

* Use bang because `-L` does not change exit status
ImpSy pushed a commit to spotinst/jupyterlab that referenced this pull request Jan 7, 2025
* Add a test for extension toggling the system level

* Do not check higher levels for `system` level

* Add sudo

* Fix test

* Debug CI

* Try with a different extension

* Use bang because `-L` does not change exit status
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot toggle extensions at system level

2 participants