Skip to content

Increase color contrast of operators in code editor#17173

Merged
krassowski merged 7 commits into
jupyterlab:mainfrom
hxrshxz:contrast
Jan 27, 2025
Merged

Increase color contrast of operators in code editor#17173
krassowski merged 7 commits into
jupyterlab:mainfrom
hxrshxz:contrast

Conversation

@hxrshxz

@hxrshxz hxrshxz commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

References

Fixes #14255

Code changes

Changed the color of the var --jp-mirror-editor-operator-color: in both light and dark themes

User-facing changes

Before After
Light theme - image image
Dark theme - image image

Backwards-incompatible changes

None

@jupyterlab-probot

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions Bot added pkg:themes tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Jan 15, 2025
@krassowski krassowski added the bug label Jan 15, 2025
@krassowski krassowski added this to the 4.3.x milestone Jan 15, 2025
@hxrshxz

hxrshxz commented Jan 15, 2025

Copy link
Copy Markdown
Contributor Author

I am having problems with jlpm playwright test --update-snapshots. I haven't been able to debug it properly . My exams are nearing, so I want to contribute instead of troubleshooting. I will fix this after my exams this month.

Could you please comment - "bot please update snapshots" for me?also The documentation says the bot can do this.. does it not work anymore? like does it only work if you comment? i am a little confused -
image

@krassowski

Copy link
Copy Markdown
Member

Could you please comment - "bot please update snapshots" for me?also The documentation says the bot can do this.. does it not work anymore? like does it only work if you comment? i am a little confused -

We had to restrict it to a subset of users with higher privileges to mitigate security risks. The documentation needs to be updated.

@github-actions

Copy link
Copy Markdown
Contributor

Galata snapshots updated.

@krassowski krassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hxrshxz!

@krassowski krassowski changed the title Code colors contrast fixed Increase color contrast of operators in code editor Jan 27, 2025
@krassowski krassowski merged commit b319b44 into jupyterlab:main Jan 27, 2025
@krassowski

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 4.3.x

@lumberbot-app

lumberbot-app Bot commented Jan 27, 2025

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b319b444094f97a1c9bb31f5be2652bdbf9b2900
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #17173: Increase color contrast of operators in code editor'
  1. Push to a named branch:
git push YOURFORK 4.3.x:auto-backport-of-pr-17173-on-4.3.x
  1. Create a PR against branch 4.3.x, I would have named this PR:

"Backport PR #17173 on branch 4.3.x (Increase color contrast of operators in code editor)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

krassowski pushed a commit to krassowski/jupyterlab that referenced this pull request Jan 28, 2025
krassowski added a commit that referenced this pull request Jan 28, 2025
…ors in code editor) (#17237)

* Backport PR #17173: Increase color contrast of operators in code editor

* Update Playwright Snapshots

---------

Co-authored-by: harsh kumar <135993950+hxrshxz@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code colors have insufficient contrast

2 participants