Fix stdin input triggering cell re-execution on Shift+Enter#17565
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
krassowski
approved these changes
May 21, 2025
krassowski
left a comment
krassowski
left a comment
Member
There was a problem hiding this comment.
Pretty neat. Fixes the issue, I tested this with:
x = None
while x != "x":
x = input()and holding Shift + Enter.
I wondered if any other function could be affected by this change, but I tested that tab navigation, arrow navigation and search still work.
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 21, 2025
…ution on Shift+Enter
krassowski
pushed a commit
that referenced
this pull request
May 22, 2025
…hift+Enter (#17585) Co-authored-by: Darshan Poudel <pranishpoudel10@gmail.com>
kjayan
pushed a commit
to kjayan/jupyterlab
that referenced
this pull request
Jun 10, 2025
github-actions
Bot
added
the
status:resolved-locked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17564
Description
This PR updates the
Stdinwidget to callevent.stopPropagation()at the very beginning of thehandleEventmethod. This ensures that key events likeShift+Enterdo not bubble up to notebook-level handlers, preventing unintended cell re-execution.