Add a setting to disable the dock panel padding#18760
Conversation
|
Thanks for making a pull request to jupyterlab! |
krassowski
left a comment
There was a problem hiding this comment.
I like the idea. I would use this setting in a few places myself.
It could be more discoverable if it was added in Theme settings but I see how it belongs in Shell given that this element is only used by JupyterLab Shell.
I also wondered if we should call it --jp-private-dock-panel-padding to avoid confusing theme authors who may want to set it to to a different value say 3px, but I think if they set it on :root then it will still work as expected.
|
Thanks for the review!
That makes sense, just pushed a new commit to do that rename. |
References
Some users would prefer to have a more compact dock panel to save a few pixels here and there.
So this PR proposes to add a new setting to the JupyterLab shell to allow for such control on the dock panel.
Code changes
--jp-dock-panel-paddingCSS variable so themes can control the value directly, without adding it explicitly to the base themesUser-facing changes
The default stays the same as before.
jupyterlab-dockpanel-padding.mp4
Backwards-incompatible changes
None
AI usage