Skip to content

Rename FooWidget -> Foo (rebased)#2177

Merged
blink1073 merged 21 commits into
jupyterlab:masterfrom
blink1073:pr/2166
May 10, 2017
Merged

Rename FooWidget -> Foo (rebased)#2177
blink1073 merged 21 commits into
jupyterlab:masterfrom
blink1073:pr/2166

Conversation

@blink1073

Copy link
Copy Markdown
Contributor

Fixes #2090

We have decided to not use Widget in the names of Widget subclasses anymore.

@blink1073

Copy link
Copy Markdown
Contributor Author

I verified the affected widgets work as intended, and fixed missing styling on the CSV viewer toolbar.

@ellisonbg

Copy link
Copy Markdown
Contributor

Thanks, once the tests pass, I will merge!

@blink1073

Copy link
Copy Markdown
Contributor Author

Docs test failure is expected (chicken and egg problem), merging.

@blink1073 blink1073 merged commit 2cf3ee4 into jupyterlab:master May 10, 2017
@blink1073 blink1073 deleted the pr/2166 branch May 16, 2017 21:08
@blink1073 blink1073 mentioned this pull request May 16, 2017
@lock lock Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use Widget in names of classes that subclass Widget

2 participants