Skip to content

Better handling of extensions that provide both prebuilt and source extensions.#9489

Merged
jasongrout merged 1 commit into
jupyterlab:masterfrom
afshin:fix-9277
Dec 18, 2020
Merged

Better handling of extensions that provide both prebuilt and source extensions.#9489
jasongrout merged 1 commit into
jupyterlab:masterfrom
afshin:fix-9277

Conversation

@afshin

@afshin afshin commented Dec 17, 2020

Copy link
Copy Markdown
Member

References

Fixes #9277

Code changes

  • Adds handling of prebuilt extensions in the build api handler check to prevent showing a build notice for a shadowed source extension.
  • Ignores shadowed source extensions in the extension manager api handler to prevent showing shadowed source extensions.

User-facing changes

Better handling of extensions that provide both prebuilt and source extensions.

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode

Copy link
Copy Markdown

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.0 milestone Dec 17, 2020
@jasongrout

Copy link
Copy Markdown
Contributor

Thanks!

@jasongrout jasongrout merged commit 6f4ba75 into jupyterlab:master Dec 18, 2020
jasongrout added a commit to jasongrout/jupyterlab that referenced this pull request Dec 18, 2020
@jasongrout jasongrout mentioned this pull request Dec 18, 2020
jasongrout added a commit that referenced this pull request Dec 18, 2020
@github-actions github-actions Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Jun 17, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Federated bundle (for JLab>=3) and source bundle (for JLlab<3) in 1 pypi package

3 participants