Skip to content

Fix contrast of debugger icon when selected#9851

Merged
blink1073 merged 1 commit into
masterfrom
krassowski-bug-selectable
Feb 22, 2021
Merged

Fix contrast of debugger icon when selected#9851
blink1073 merged 1 commit into
masterfrom
krassowski-bug-selectable

Conversation

@krassowski

@krassowski krassowski commented Feb 22, 2021

Copy link
Copy Markdown
Member

The debugger icon does not have proper contrast when items with this icon are selected. This PR fixes it by adding jp-icon-selectable class.

Code changes

N/A

User-facing changes

Before:

Screenshot from 2021-02-22 19-10-10

After:

Screenshot from 2021-02-22 19-13-40

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode

Copy link
Copy Markdown

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 3.1 milestone Feb 22, 2021
@blink1073 blink1073 merged commit 54a2f9b into master Feb 22, 2021
@jtpio jtpio deleted the krassowski-bug-selectable branch February 22, 2021 21:16
@bollwyvl

Copy link
Copy Markdown
Contributor

Nice fix... so over on some other stuff, I found a lot of debugger styles are pretty inflexible... still mired in #9779, but might take a crack at it.

However: (and germane to #9779) debugger has some great stuff for making a DataGrid look good in the face of theming (didn't know i was using even using it!), but it's all hidden under private methods... it would be awesome if there was a ui-components ThemedDataGrid or something that encapsulated that behavior.

Also @krassowski: we'd need to land a bunch of changes to debugger if we want to do any gutter work on lsp, as it kinda stomps over everything.

@jtpio

jtpio commented Feb 23, 2021

Copy link
Copy Markdown
Member

debugger has some great stuff for making a DataGrid look good in the face of theming (didn't know i was using even using it!), but it's all hidden under private methods... it would be awesome if there was a ui-components ThemedDataGrid or something that encapsulated that behavior.

Yeah I think the idea was to extract it into its own plugin so it could also be used for the csv viewer (or any other plugin).

@blink1073 blink1073 added the bug label Jul 21, 2021
@github-actions github-actions Bot added the status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion. label Jan 18, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug pkg:ui-components status:resolved-locked Closed inactive issues are locked after a while. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants