Skip to content

examples/agent-sandbox-rl: create the namespace in setup - #1549

Merged
kubernetes-prow[bot] merged 4 commits into
kubernetes-sigs:mainfrom
vincent0426:rl-example-namespace
Sep 8, 2026
Merged

kubernetes-prow[bot] merged 4 commits into
kubernetes-sigs:mainfrom
vincent0426:rl-example-namespace

Conversation

@vincent0426

@vincent0426 vincent0426 commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

agent-sandbox-rl quickstart uses a namespace that setup never creates. Adds the kubectl create namespace step to setup and renames the namespace to agent-sandbox-rl.

Release Note

NONE

Summary by CodeRabbit

  • Documentation
    • Updated setup instructions and examples to use the agent-sandbox-rl namespace.
    • Added guidance to create the namespace before running the fleet.
    • Updated notebook, performance-report, integration, recycling, and reaper commands to use the new namespace.

Copilot AI lite review requested due to automatic review settings September 4, 2026 06:29
@github-project-automation github-project-automation Bot moved this to Backlog in Agent Sandbox Sep 4, 2026
@netlify

netlify Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit 670a238
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/6a9b7ee09d8fc20008add632

@kubernetes-prow
kubernetes-prow Bot requested review from igooch and justinsb September 4, 2026 06:29
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @vincent0426. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 31c94051-b4fe-4770-889b-c5e1c1970151

📥 Commits

Reviewing files that changed from the base of the PR and between 9592d7c and 670a238.

📒 Files selected for processing (2)
  • examples/agent-sandbox-rl/examples/rl_integration.md
  • examples/agent-sandbox-rl/examples/run_swebench_recycle.py

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The RL examples now use agent-sandbox-rl consistently. The README adds namespace creation instructions and updates commands, reports, notebook defaults, integration examples, and reaper documentation.

Changes

RL namespace alignment

Layer / File(s) Summary
Update RL example namespace configuration
examples/agent-sandbox-rl/README.md, examples/agent-sandbox-rl/examples/deepswe_eval_nb.ipynb, examples/agent-sandbox-rl/performance_reports/README.md, examples/agent-sandbox-rl/agent_sandbox_rl/reaper.py
Setup instructions, commands, report output, notebook defaults, and reaper examples now use agent-sandbox-rl. The README adds namespace creation instructions.
Update RL integration examples
examples/agent-sandbox-rl/examples/rl_integration.md, examples/agent-sandbox-rl/examples/run_swebench_recycle.py
ClusterConfig examples and recycling commands now use agent-sandbox-rl.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 670a2

The quickstart examples now consistently use the agent-sandbox-rl namespace. No current merge-readiness risk remains.

Suggested reviewers: esposem, janetkuo, tomergee

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly identifies the main change: creating the namespace during setup for the agent-sandbox-rl example.
Description check ✅ Passed The description clearly explains the setup fix and namespace rename. It includes a release note of NONE. The issue section heading is omitted, but no linked issue is required by the available context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Documentation-only changes that consistently create and reference the intended namespace with no apparent behavioral risk.

Pull request overview

Updates the examples/agent-sandbox-rl quickstart documentation to consistently use a dedicated namespace (agent-sandbox-rl) and to explicitly create it during setup, avoiding preflight failures due to a missing namespace.

Changes:

  • Add a setup step to create the agent-sandbox-rl namespace before running fleet preflight/quickstart.
  • Rename the namespace used throughout the RL example docs/scripts from rl-tunix-swebench (and one default mention) to agent-sandbox-rl.
  • Update the accompanying evaluation notebook to default to the new namespace.
File summaries
File Description
examples/agent-sandbox-rl/README.md Adds explicit namespace creation step and standardizes example configs/env vars to agent-sandbox-rl.
examples/agent-sandbox-rl/performance_reports/README.md Updates report-generation command to use NAMESPACE=agent-sandbox-rl.
examples/agent-sandbox-rl/examples/deepswe_eval_nb.ipynb Updates notebook default namespace to agent-sandbox-rl.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@esposem

esposem commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2026
@vincent0426

Copy link
Copy Markdown
Contributor Author

/retest

@kubernetes-prow

Copy link
Copy Markdown

@vincent0426: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aditya-shantanu

Copy link
Copy Markdown
Collaborator

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2026
@vincent0426

Copy link
Copy Markdown
Contributor Author

Seems flaky

Comment thread examples/agent-sandbox-rl/README.md Outdated
Comment thread examples/agent-sandbox-rl/README.md Outdated
Comment thread examples/agent-sandbox-rl/README.md
Copilot AI review requested due to automatic review settings September 5, 2026 02:11
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The added “create namespace” step uses a non-idempotent command that contradicts the “if it doesn't already exist” wording and will fail on reruns unless adjusted.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread examples/agent-sandbox-rl/README.md
Copilot AI review requested due to automatic review settings September 5, 2026 02:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Some other examples/agent-sandbox-rl docs/scripts still hard-code the old rl namespace, so the rename is currently inconsistent and can confuse users.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread examples/agent-sandbox-rl/README.md
Copilot AI review requested due to automatic review settings September 5, 2026 02:30
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are straightforward documentation/example updates that consistently align the quickstart with an explicitly-created namespace.

Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@vincent0426

Copy link
Copy Markdown
Contributor Author

@janetkuo thanks for review, addressed all issues!

@aditya-shantanu aditya-shantanu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of @janetkuo's points are addressed at 670a238: namespace is agent-sandbox-rl everywhere (including the examples/ subdir docs and scripts Copilot flagged), the create-namespace step is conditional-worded, and the repo-centric README phrasing is gone.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, esposem, vincent0426

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2026
@aditya-shantanu

Copy link
Copy Markdown
Collaborator

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 9d53ced into kubernetes-sigs:main Sep 8, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent Sandbox Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants