Add drop all option & bug fix - #89
Merged
Cheney Zhang (zc277584121) merged 3 commits intoJul 23, 2025
Merged
Conversation
Ensure text field is always returned on the query, as it's later used.
Collaborator
|
Matan Ben-Tov (@matanbt) thanks, it's a good optimization, but some lint check failed,please fix it according to the CONTRIBUTING.md guide. And btw, the async function |
Contributor
Author
|
Cheney Zhang (zc277584121)
merged commit Jul 23, 2025
0903534
into
langchain-ai:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First, thanks for maintaining this useful wrapper for Milvus :) Using it, I encountered a small issue, and a feature that I had to implement externally; so I thought I'd add them here.
search_by_metadata(): The function assumes the text field is requested by the function caller, although they might require metadata alone. Such requests currently result in an exception. Thus, to ensure text field is always returned on the database query, I suggest simply adding it, when missing.drop(): Resetting the vectorstore by dropping all rows is very useful, and in fact currently enabled only on initialization (as part of__init__()). I suggest to decouple it into a method (drop(); feel free to offer other names), exposing it for external use.