fix(openai): accept valid responses that are falsy at runtime - #35307
Merged
ccurme (ccurme) merged 2 commits intoFeb 19, 2026
Merged
Conversation
Mattijs Ugen (akaIDIOT)
requested review from
ccurme (ccurme) and
Mason Daugherty (mdrxy)
as code owners
February 18, 2026 13:39
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using structured output through
model.with_structured_output(MyModel)using aMyModelclass definition that happens to implement magic methods that influence the truthiness of an instance, a valid response that evaluates toFalsecauses_oai_structured_outputs_parserto fall through all of the options reading the response, concluding that the response must be faulty. Moving from a truthiness check to a presence check (is not None) fixes this; valid responses of my model class that happen to have length 0 are now returned as expected.See the added test for a minimal example of this behaviour (the test fails without the single line change in
langchain_openai/chat_models/base.py).