fix(openai): close PIL Image handles in token counting to prevent fd leak - #35742
Merged
Merged
Conversation
…leak Wrap Image.open() calls in context managers to ensure file descriptors are properly released after reading image dimensions. Addresses the existing "close things (context managers)" comment that was not followed. Fixes langchain-ai#35728 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Matt Van Horn (mvanhorn)
requested review from
ccurme (ccurme) and
Mason Daugherty (mdrxy)
as code owners
March 11, 2026 06:15
Contributor
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
|
Merging this PR will not alter performance
Comparing Footnotes
|
ccurme (ccurme)
previously approved these changes
Mar 12, 2026
This reverts commit 63c8f77.
ccurme (ccurme)
merged commit Mar 12, 2026
9521c67
into
langchain-ai:master
154 of 157 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image.open()calls in_get_image_dimensions()with context managers (withstatements) to ensure PIL Image handles are properly closed and file descriptors released.# close things (context managers)that was never implemented.Fixes #35728
Test plan