fix(langchain,openai): only set strict=True on tools for OpenAI-compatible models in ProviderStrategy - #38370
Merged
Merged
Conversation
strict=True on tools for OpenAI-compatible models in ProviderStrategy
Mason Daugherty (mdrxy)
approved these changes
Jun 22, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
ProviderStrategy,create_agentunnecessarily setsstrict=Trueon tools for all providers. This is only needed for OpenAI / chat completions. Here we unsetstrict. For OpenAI:BaseChatOpenAI.bind_tools(as a convenience to users callingmodel.bind_toolsdirectly)create_agentfactory logic so that things will not break for users who upgradelangchainbut notlangchain-openai.Note: payloads for OpenAI are tested here and appear unchanged: https://github.com/langchain-ai/langchain/blob/master/libs/langchain_v1/tests/unit_tests/agents/test_response_format_integration.py
Quick test: