Skip to content

test(openai): clarify async API key sync failure trace - #38379

Merged
Mason Daugherty (mdrxy) merged 1 commit into
masterfrom
mdrxy-openai/comment-async-api-key-trace
Jun 23, 2026
Merged

test(openai): clarify async API key sync failure trace#38379
Mason Daugherty (mdrxy) merged 1 commit into
masterfrom
mdrxy-openai/comment-async-api-key-trace

Conversation

@mdrxy

@mdrxy Mason Daugherty (mdrxy) commented Jun 23, 2026

Copy link
Copy Markdown
Member

Clarifies why the async callable API-key integration test intentionally creates a failed ChatOpenAI run in scheduled LangSmith traces. The sync invocation is expected to fail because async API-key callables are only valid for async model methods.

@github-actions github-actions Bot added integration PR made that is related to a provider partner package integration internal openai `langchain-openai` package issues & PRs size: XS < 50 LOC tests PRs made that add, modify, or remove tests labels Jun 23, 2026
@mdrxy
Mason Daugherty (mdrxy) merged commit 844cef4 into master Jun 23, 2026
93 checks passed
@mdrxy
Mason Daugherty (mdrxy) deleted the mdrxy-openai/comment-async-api-key-trace branch June 23, 2026 00:16

@open-swe open-swe Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in WebView Open SWE trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration PR made that is related to a provider partner package integration internal openai `langchain-openai` package issues & PRs size: XS < 50 LOC tests PRs made that add, modify, or remove tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant