Skip to content

test(core): avoid version-dependent runnable snapshots - #39705

Merged
Mason Daugherty (mdrxy) merged 2 commits into
masterfrom
mdrxy/core/avoid-version-snapshot
Aug 18, 2026
Merged

test(core): avoid version-dependent runnable snapshots#39705
Mason Daugherty (mdrxy) merged 2 commits into
masterfrom
mdrxy/core/avoid-version-snapshot

Conversation

@mdrxy

@mdrxy Mason Daugherty (mdrxy) commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Runnable snapshots currently embed the exact langchain-core version, forcing unrelated snapshot rewrites during every release. Normalize only the current VERSION to a stable placeholder before comparison, so missing or stale version metadata still fails.

Made by Open SWE

@mdrxy @open-swe
fix(core): avoid version-dependent runnable snapshots
62d7477 
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
@github-actions github-actions Bot added core `langchain-core` package issues & PRs fix For PRs that implement a fix internal size: S 50-199 LOC labels Aug 17, 2026
@mdrxy
Mason Daugherty (mdrxy) marked this pull request as ready for review August 17, 2026 20:56
@mdrxy Mason Daugherty (mdrxy) changed the title fix(core): avoid version-dependent runnable snapshots test(core): avoid version-dependent runnable snapshots Aug 17, 2026
@github-actions github-actions Bot added tests PRs made that add, modify, or remove tests and removed fix For PRs that implement a fix labels Aug 17, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks
⏩ 2 skipped benchmarks1

Comparing mdrxy/core/avoid-version-snapshot (0e90fe1) with master (65e5e3c)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (b28d8c4) during the generation of this report, so 65e5e3c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

open-swe[bot]
open-swe Bot reviewed Aug 17, 2026
View reviewed changes

@open-swe open-swe Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in Web • View Open SWE trace

@mdrxy
Merge remote-tracking branch 'origin/master' into mdrxy/core/avoid-ve…
0e90fe1 
…rsion-snapshot

# Conflicts:
#	libs/core/tests/unit_tests/runnables/__snapshots__/test_fallbacks.ambr
#	libs/core/tests/unit_tests/runnables/__snapshots__/test_runnable.ambr
@mdrxy
Mason Daugherty (mdrxy) merged commit 72fb009 into master Aug 18, 2026
99 checks passed
@mdrxy
Mason Daugherty (mdrxy) deleted the mdrxy/core/avoid-version-snapshot branch August 18, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@open-swe open-swe[bot] open-swe[bot] left review comments
@eyurtsev Eugene Yurtsev (eyurtsev) eyurtsev left review comments

Assignees

No one assigned

Labels

core `langchain-core` package issues & PRs internal size: S 50-199 LOC tests PRs made that add, modify, or remove tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdrxy @eyurtsev