feat(fireworks): add document reranking - #39732
Merged
ccurme (ccurme) merged 6 commits intoAug 20, 2026
Merged
Conversation
Noah Dylan Pelegrini (11adyy)
requested review from
ccurme (ccurme) and
Mason Daugherty (mdrxy)
as code owners
August 18, 2026 23:42
github-actions
Bot
added
feature
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
…ial leakage Prevent OpenAI credentials from being sent to Fireworks API when FIREWORKS_API_KEY is not configured. When no client is injected and FIREWORKS_API_KEY is absent, the OpenAI SDK's fallback mechanism would use OPENAI_API_KEY as a fallback. This would cause the OpenAI credential to be sent as Authorization header to api.fireworks.ai, authenticating with the wrong provider. Now explicitly require FIREWORKS_API_KEY when no client is supplied. Fixes security issue identified in code review. Co-authored-by: open-swe[bot] <215916821+open-swe[bot]@users.noreply.github.com> Signed-off-by: Noah Dylan <111adyydev@gmail.com>
ccurme (ccurme)
left a comment
ccurme (ccurme)
left a comment
Collaborator
There was a problem hiding this comment.
Noah Dylan Pelegrini (@11adyy) this fails out of the box for me with
ValueError: not enough values to unpack (expected 2, got 0)
Did you run this yourself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39340
Add
FireworksReranktolangchain-fireworks, allowing users to rerank LangChain documents with Fireworks reranking models through the standardBaseDocumentCompressorinterface.Release note
Add native Fireworks document reranking support.
Verification
Social handles
LinkedIn: https://linkedin.com/in/11adyy