Repository navigation
[@mantine/core] Combobox: Set aria-disabled on disabled Combobox.Option - #9236
Merged
rtivital merged 2 commits intoOct 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new rerender test remounts the component instead of verifying attribute removal after a prop update.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds assistive-technology support for disabled combobox options.
Changes:
- Adds
aria-disabledto disabledCombobox.Optionelements. - Adds direct and
Selectintegration tests.
| File | Description |
|---|---|
ComboboxOption.tsx |
Exposes disabled state through ARIA. |
ComboboxOption.test.tsx |
Tests disabled ARIA behavior. |
Select.test.tsx |
Verifies propagation to Select options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lavinhoque33
force-pushed
the
fix/combobox-option-aria-disabled
branch
from
October 2, 2026 02:44
09c4088 to
f522649
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
Combobox.Optionwithdisabledrendersdata-combobox-disabledon therole="option"element but neveraria-disabled. Keyboard navigation already skips the option, but assistive technology in browse/virtual-cursor mode still announces it as available. The same applies toSelect/MultiSelectitems withdisabled: true, which render throughOptionsDropdown.Fix
Set
aria-disabled="true"on the option element whendisabledis set, and omit the attribute otherwise, as the WAI-ARIA APG listbox and combobox patterns expect.OptionsDropdownalready forwardsdisabledtoCombobox.Option, soSelect,MultiSelect,AutocompleteandTagsInputpick this up without further changes.Closes #9233
Testing
ComboboxOption.test.tsx: assertsaria-disabled="true"whendisabledand that the attribute is absent otherwise. Fails on master.Select.test.tsx:dropdownOpenedwith one disabled item; only that option carriesaria-disabled. Fails on master.