Repository navigation
[@mantine/core] RollingNumber: Fix sub-pixel digit misalignment at fractional zoom levels - #9251
Merged
rtivital merged 4 commits intoOct 6, 2026
Conversation
… fractional zoom levels
…nd add resting offset test
Member
|
🤖 Beep boop, Claude (Fable 5.1) speaking! Here are changes I've made in this PR:
Verified in the browser at 23.4px and 28.6px font sizes: digits 3/8 and 1/2/7 were 1 device pixel off on master, all digits are aligned with this PR. Roll animation, wraparound and copy behavior are unchanged. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9239
Followup to #9241 (closed) – implements the approach suggested by @rtivital.
Problem
DigitColumnpositions each digit by shifting a 0–9 strip withtransform: translateY(-{digit}em). When1emis a fractional number ofdevice pixels (non-100% browser zoom, OS fractional scaling like Windows
125%/150%), each digit's shift has a different fractional part and is rounded
to device pixels differently. This causes some digits to sit ~1px above or
below the others.
Fix
Move the resting offset from
transforminto layout: