Repository navigation
fix: typing for numpy as indices - #10014
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Plotly selection extraction logic to avoid NumPy scalar indices (e.g., np.int64) leaking into list/sequence indexing, which can break type-checking after NumPy typing/stub updates.
Changes:
- Iterate over NumPy-produced index arrays via
.tolist()in_extract_bars_numpy. - Iterate over
np.where(mask)[0]via.tolist()in_extract_funnel_stages_numpy, and remove the now-redundantint(i)cast when calling_build_funnel_stage_point.
kirangadhave
approved these changes
Jun 29, 2026
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.12-dev14 |
williambdean
pushed a commit
to williambdean/marimo
that referenced
this pull request
Sep 6, 2026
## 📝 Summary CI is currently broken due to a numpy update (e.g. https://github.com/marimo-team/marimo/actions/runs/28386107852/job/84108138102) This uses `.tolist()` which returns numbers opposed to numpy primitives for indexing <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/marimo-team/marimo/pull/10014?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source](https://kapook.pages.dev/bl-https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img](https://kapook.pages.dev/bl-https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a](https://kapook.pages.dev/bl-https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a){kind=link}
📝 Summary
CI is currently broken due to a numpy update (e.g. https://github.com/marimo-team/marimo/actions/runs/28386107852/job/84108138102)
This uses
.tolist()which returns numbers opposed to numpy primitives for indexing