Repository navigation
fix(anywidget): preserve virtual ESM URLs - #10687
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
You’re at about 99% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
williambdean
pushed a commit
to williambdean/marimo
that referenced
this pull request
Sep 6, 2026
## 📝 Summary Anywidget `_esm` values may already be importable URLs, including marimo virtual files produced by `mo_data.js`. `EsmSpec.from_esm()` previously sent those virtual-file URLs back through JavaScript virtualization, creating a second file whose contents were only the first URL. Importing that file failed with `Unexpected token '.'`. Preserve supported virtual-file, HTTP(S), and JavaScript data URLs when minting an `EsmSpec`. Inline JavaScript still becomes a virtual file, including source that begins with a URL-like JavaScript label. URL recognition mirrors the frontend's trusted virtual-file shape so malformed paths are not passed through. ## 📋 Pre-Review Checklist - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (not applicable: focused bug fix with no public API change). - [ ] Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it. - [ ] Video or media evidence is provided for any visual changes (not applicable: backend URL handling only). ## ✅ Merge Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] Documentation has been updated where applicable, including docstrings for API changes (not applicable: no public API change). - [x] Tests have been added for the changes made. > Written by GPT-5.6 on Codex
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Anywidget
_esmvalues may already be importable URLs, including marimo virtual files produced bymo_data.js.EsmSpec.from_esm()previously sent those virtual-file URLs back through JavaScript virtualization, creating a second file whose contents were only the first URL. Importing that file failed withUnexpected token '.'.Preserve supported virtual-file, HTTP(S), and JavaScript data URLs when minting an
EsmSpec. Inline JavaScript still becomes a virtual file, including source that begins with a URL-like JavaScript label. URL recognition mirrors the frontend's trusted virtual-file shape so malformed paths are not passed through.📋 Pre-Review Checklist
✅ Merge Checklist