Repository navigation
feat(command-mode): add shortcut to create a SQL cell below - #10701
Merged
Light2Dark merged 3 commits intoSep 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
documentation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Aniket-a14
marked this pull request as ready for review
August 29, 2026 17:13
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Light2Dark
requested changes
Sep 1, 2026
Comment on lines
+560
to
+564
| const importCellId = maybeAddMarimoImport({ | ||
| autoInstantiate: true, | ||
| createNewCell: actions.createNewCell, | ||
| fromCellId: cellId, | ||
| }); |
Member
There was a problem hiding this comment.
I think you likely want to add a marimo Import before the cell. Right now it's
selected cell -> import cell -> new sql cell.
There is a before keywords for maybeAddMarimoImport
And you should add tests for this feature too
Press Esc then q to create and focus a new SQL cell below the current cell, without executing it. Mirrors the existing b (create cell below) shortcut. Adds the marimo import if missing. Closes marimo-team#10688
Aniket-a14
force-pushed
the
feat/command-mode-sql-cell-shortcut
branch
from
September 6, 2026 09:02
233d3ef to
88f468b
Compare
Contributor
Author
|
@Light2Dark Addressed the import ordering and added tests in 88f468b. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10688.
Adds
command.createSqlCellAfter, bound toqin command mode by default. PressingEscthenqcreates and focuses a new SQL cell below the current cell without executing it, adding themarimoimport first if it's missing. The existingbshortcut (plain cell) is unchanged.Test plan
pnpm typecheck/pnpm lintpassEsc→qinserts a focused SQL cell below, in the correct order relative to the auto-insertedimport marimo as mo, without running any cell;Esc→bstill creates a plain cell (regression check)