Repository navigation
Fix image_compare expand output bug - #10907
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation directly addresses the reported bug and includes regression coverage.
Pull request overview
Fixes vertical image_compare outputs being fixed at 400px, allowing them to expand naturally.
Changes:
- Uses
autoheight when no explicit height is provided. - Adds regression coverage for horizontal and vertical directions.
File summaries
| File | Description |
|---|---|
ImageComparisonComponent.tsx |
Removes the vertical fixed-height default. |
ImageComparisonComponent.test.tsx |
Tests automatic container sizing. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const containerStyle: React.CSSProperties = { | ||
| width: width || "100%", | ||
| height: height || (direction === "vertical" ? "400px" : "auto"), | ||
| height: height || "auto", |
|
@marthacryan , can you:
|
Coverage Report for ./frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Thankyou kings/queens!!! <3 |
Fixes #10902. The "Expand Output" button wasn't doing anything for the output of the following code snippet:
It's unclear why the original line of code was written but I tested this change and it fixed the bug that was reported.