filetype command-line argument regression

[zoomosis]

Version: 2.0.15-dev.129
Commit hash: 5a62a8e
Compiled on February 11, 2025

Running micro -filetype mail mymail correctly sets the filetype to mail however the filetype erroneously switches to unknown after the file is saved with Ctrl+S.

[Andriamanitra]

This bug was introduced in #3625, versions before that commit work as expected.

[niten94]

I think it is a general bug in func (b *Buffer) ReloadSettings(...) introduced in 2.0.14 and not just #3625. The bug can be reproduced when also running > reload instead of Ctrl+S.

When looking a bit, it seems like config.VolatileSettings too has to be checked here like in line 34:
https://github.com/zyedidia/micro/blob/5a62a8ead4af741e4fc5f850fcb846974859c5a0/internal/buffer/settings.go#L16

Edit: I just realized that onBufferOptionChanged does not seem to be also called when filetype is changed in ReloadSettings.

[JoeKar]

I think it is a general bug in func (b *Buffer) ReloadSettings(...) introduced in 2.0.14 and not just #3625. The bug can be reproduced when also running > reload instead of Ctrl+S.

When looking a bit, it seems like config.VolatileSettings too has to be checked here like in line 34:

Absolutely right. The filetype option is a special one and needs separate treatment prior the rest.
Unfortunately in exactly this condition/check I forgot to add the mentioned config.VolatileSettings.

Edit:
Created #3662 which should be worth testing to prevent further regression.

[dmaluka]

#3662 seems to work well for me.

While testing it, I've encountered a couple of other related issues/observations (not caused by #3662). I'm not sure yet if we should qualify them as bugs or not.

1. I run micro -filetype go foo, do something, then open my init.lua in another tab (in order to add onBufferOptionChanged to test 93c11d6) -> my init.lua is suddenly highlighted all red, because its filetype is set to Go instead of Lua.
   One may argue this is "expected behavior", but...

2. So I add onBufferOptionChanged to my init.lua:

function onBufferOptionChanged(buf, option, old, new)
    micro.InfoBar():Message("option ", option, " changed: ", old, " ", new)
end

and then when I execute micro -filetype go foo again, I get this:

Plugin initlua: init:267: attempt to index a non-table object(nil) with key 'Message'
stack traceback:
	init:267: in function <init:266>
	[G]: in function 'SetOption'
	ftoptions:8: in main chunk
	[G]: ?

Ok, I change it to:

function onBufferOptionChanged(buf, option, old, new)
    if micro.InfoBar() ~= nil then
        micro.InfoBar():Message("option ", option, " changed: ", old, " ", new)
    end
end

Now it doesn't throw the error anymore, but once micro started, I see this in the infobar:

option tabstospaces changed: true false                                                                                                                                                                            

(again, triggered by the ftoptions plugin)

[niten94]

2. So I add onBufferOptionChanged to my init.lua: ...

The easiest solution I could think is something like setting filetype to unknown when creating a buffer with a type other than BTDefault, BTScratch and BTStdout, but I still think the type should be checked in plugins.

This issue is related: #2389