Repository navigation
Conversation
nickbair-nylas
approved these changes
Jan 10, 2025
nickbair-nylas
left a comment
nickbair-nylas
left a comment
Contributor
There was a problem hiding this comment.
LGTM, worth adding a test case for this?
AaronDDM
reviewed
Jan 11, 2025
AaronDDM
left a comment
AaronDDM
left a comment
Contributor
There was a problem hiding this comment.
Thanks Kiran! Could you add a test, ideally for a legitimate error that we're experiencing.
Contributor
Author
|
@AaronDDM @nickbair-nylas I think there are some tests regarding this in http_client.spec file? Would you be able to sanity check if that is doing the same? |
Contributor
Contributor
Author
|
Added a test for this change. One of the github action is failing. I am not sure if it's related to this: |
AaronDDM
approved these changes
Jan 21, 2025
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to unexpected errors such as Bad Gateway, the response object is of Instance string, while trying to fetch the provider_error we return a Ruby error of
undefined methodfetch' for "Bad Gateway":String`This PR addresses the type before parsing the provider_error property
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.