Test latest play#18624
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Play instrumentation/testing to exercise newer Play dependencies (including Play 3 / Scala 3 artifacts) and extends Play WS matching to handle additional class names seen in newer dependency layouts.
Changes:
- Extend Play WS
HandlerPublishertype matching to cover both shaded and unshaded class names. - Add Play 3 test suites and corresponding new Play WS and Play MVC test sources under
src/play3Test. - Update Gradle build logic and latest-deps version pins to support Play 2.8/2.x and Play 3 testing (including Pekko-based dependencies).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/play/play-ws/play-ws-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/playws/common/v1_0/HandlerPublisherInstrumentation.java | Match both shaded and unshaded HandlerPublisher class names. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playws/v3_0/PlayWsClientBaseTest.java | Add Play 3 WS client base test using Pekko + shaded AHC. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playws/v3_0/PlayScalaWsClientTest.java | Add Play 3 Scala WS client test implementation. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playws/v3_0/PlayScalaStreamedWsClientTest.java | Add Play 3 Scala streamed WS client test implementation. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playws/v3_0/PlayJavaWsClientTest.java | Add Play 3 Java WS client test implementation. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playws/v3_0/PlayJavaStreamedWsClientTest.java | Add Play 3 Java streamed WS client test implementation. |
| instrumentation/play/play-ws/play-ws-2.1/javaagent/build.gradle.kts | Add muzzle entry + Play 3 test suite and Pekko test instrumentation dependencies. |
| instrumentation/play/play-mvc/play-mvc-2.6/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v3_0/PlayServerTest.java | Add Play 3 MVC server test coverage. |
| instrumentation/play/play-mvc/play-mvc-2.6/javaagent/src/play3Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v3_0/PlayAsyncServerTest.java | Add Play 3 async MVC server test coverage. |
| instrumentation/play/play-mvc/play-mvc-2.6/javaagent/src/play28Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v2_8/PlayServerTest.java | Fix package declaration to match v2_8. |
| instrumentation/play/play-mvc/play-mvc-2.6/javaagent/src/play28Test/java/io/opentelemetry/javaagent/instrumentation/playmvc/v2_8/PlayAsyncServerTest.java | Fix package declaration to match v2_8. |
| instrumentation/play/play-mvc/play-mvc-2.6/javaagent/build.gradle.kts | Add Play 2.8 + Play 3 suites, update deps and test task gating. |
| .github/config/latest-dep-versions.json | Add/version-pin new Play 2.x/2.8 and Play 3 coordinates used by latest-deps/suites. |
trask
approved these changes
May 9, 2026
Member
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.