fix(configuration): improve environment variable substitution to handle all the cases shown in the spec - #6757
Merged
Conversation
…le all the cases shown in the spec https://opentelemetry.io/docs/specs/otel/configuration/data-model/#environment-variable-substitution provides a number of test cases to exercise the algorithm expected for environment variable substitution. This adds those test cases and updates the processing to handle them all.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6757 +/- ##
==========================================
- Coverage 94.92% 94.92% -0.01%
==========================================
Files 377 377
Lines 12818 12827 +9
Branches 2924 2920 -4
==========================================
+ Hits 12168 12176 +8
- Misses 650 651 +1
🚀 New features to boost your workflow:
|
Contributor
Author
|
Before this change, the env var substitution was failing these added tests: and others not in the set of examples in the spec, like FOO=TRUE (YAML allows a few capitalizations of bools), |
trentm
marked this pull request as ready for review
May 22, 2026 22:54
maryliag
reviewed
Jun 3, 2026
maryliag
approved these changes
Jun 3, 2026
Merged
via the queue into
open-telemetry:main
with commit Jun 5, 2026
3bd69ce
31 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://opentelemetry.io/docs/specs/otel/configuration/data-model/#environment-variable-substitution
provides a number of test cases to exercise the algorithm expected
for environment variable substitution. This adds those test cases
and updates the processing to handle them all.