Avoid cloning file changes in TUI diff rendering - #34224
Merged
copyberry[bot] merged 1 commit intoJul 19, 2026
Merged
Conversation
## What changed - Consume and sort `DiffSummary` entries directly when building renderables. - Borrow paths and `FileChange` values in the shared row representation used by line-based summaries. - Share line-count calculation between both rendering paths. GitOrigin-RevId: b02668074def7529ff39445e9970a1fec209f02b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b02668074def7529ff39445e9970a1fec209f02b
branch
from
July 19, 2026 20:21
7b7a982 to
c86b1be
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b02668074def7529ff39445e9970a1fec209f02b
branch
July 19, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cloning file changes in TUI diff rendering
What changed
DiffSummaryentries directly when building renderables.FileChangevalues in the shared row representation used by line-based summaries.