Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Bugfix: Disable expiration date alias link followup - #10085

Merged
lookacat merged 4 commits into
masterfrom
bugfix-disable-expiraton-date-alias-line
Nov 29, 2023
Merged

Bugfix: Disable expiration date alias link followup#10085
lookacat merged 4 commits into
masterfrom
bugfix-disable-expiraton-date-alias-line

Conversation

@lookacat

@lookacat lookacat commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Description

Fix the seperator line if only one item is in the list

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

update-docs Bot commented Nov 29, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat
lookacat marked this pull request as ready for review November 29, 2023 08:15

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is some margin missing above "Delete link" for internal links. Sorry for the nitpicking 🙈

image

@lookacat
lookacat requested a review from JammingBen November 29, 2023 08:29
@lookacat
lookacat enabled auto-merge (squash) November 29, 2023 08:29

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (snapshots are failing though) 👍

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat
lookacat merged commit 4fd1da2 into master Nov 29, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the bugfix-disable-expiraton-date-alias-line branch November 29, 2023 10:56
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* Bugfix: Disable expiration date alias link followup

* Add to changelog

* Fix missing padding
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants