Unable to patch methods located inside the GlobalType (aka. <Module>)

Describe the bug

When a method is resolved inside the GlobalType (this is only possible via Module.ResolveMethod(int MDToken)) its DeclaringType property is null and when an attempt is made to patch the method, a NRE will get thrown in this function: GeneralExtensions.FullDescription(this MethodBase method)

To Reproduce

Resolve a method via its metadata token that is inside <Module> (or also known as the globaltype)
Try to apply any patch to it

Expected behavior
The patch gets applied

Screenshot

Runtime environment:

OS: Windows 10, 64bit
.NET version 4.8
Harmony version 1.2.0.1

Thanks for the analysis. I am in no means an expert in C# and the concept of a GlobalType is totally new to me. I guess I have to look over my use of DeclaringType in the whole project. Thanks.

Fixed in latest master. Please verify.

Fixed pardeike#235

Navigation Menu

Repository navigation

Unable to patch methods located inside the GlobalType (aka. <Module>) #235

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Unable to patch methods located inside the GlobalType (aka. <Module>) #235

Description

Activity

pardeike commented on Jan 16, 2020

pardeike commented on Jan 25, 2020

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions