Repository navigation
Catalog: fail closed on S3 signing snapshot lookup errors - #12620
Merged
Merged
Conversation
dimas-b
previously approved these changes
Jun 24, 2026
| requestMeta.build(), | ||
| ICEBERG_V1); | ||
| // consider an import failure as a non-existing content: | ||
| // signing will be authorized for the future location only. |
Member
There was a problem hiding this comment.
I think this comment still makes sense. Why remove it?
dimas-b
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.