Repository navigation
Add missing paging attributes to DiffResponse - #9
Merged
Merged
Conversation
XN137
approved these changes
Jul 6, 2023
XN137
left a comment
XN137
left a comment
Contributor
There was a problem hiding this comment.
i assume you tested this with the testcontainers wip branch
|
|
||
| diffs: List[DiffEntry] = desert.ib(fields.List(fields.Nested(DiffEntrySchema(), data_key="diffs"))) | ||
| has_more: bool = attr.ib(default=False, metadata=desert.metadata(fields.Bool(allow_none=True, data_key="hasMore"))) | ||
| token: str = attr.ib(default=None, metadata=desert.metadata(fields.Str(allow_none=True))) |
Contributor
There was a problem hiding this comment.
are these specific to DiffResponse or are we missing a common base class for paged responses ?
Member
Author
There was a problem hiding this comment.
Never had a base-class nor "proper, generic paging support" before
Member
Author
There was a problem hiding this comment.
BTW: REST API v1 doesn't actually support paging except for the commit-log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paging attributes became part of REST API v1 a while ago, but pynessie was never updated.