Default value for Syslog counting framing

[mabartos]

The expected behavior described in the #48036 issue seems reasonable and also the suggested approach on how to achieve it described in #48036 (comment).

It should be in compliance with RFC-5425 and RFC-6587.

@dmlloyd Could you please check it? Thanks!

• Closes: Default property values for syslog logging #48036

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f2e530c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[mabartos]

@dmlloyd @geoand Would it be possible to backport it in 3.20?

[geoand]

That's a tricky one as this could theoretically break applications that (inadvertedly and incorrectly) depend on the previous behavior. Consider the following use case:

quarkus.log.syslog.use-counting-framing=true #this comment should not be here and results in the value being `false`

If we backport then this application will no longer build.

[mabartos]

@geoand Thanks for the comment. Just thought that we could simply set the default value to false for the 3.20 backport and keeping the same functionality as before.

Consider the following use case:

I don't probably fully understand. If they explicitly specify the property, there should not be any change for them, right?

[geoand]

there should not be any change for them, right?

If they set the property in the way I showed in the hypothetical example above, with 3.20 they would effectively have quarkus.log.syslog.use-counting-framing=false while with this PR the application fails to start at all.
It's a super niche example, but as we are talking about LTS, I'd prefer to not backport unless there is a very good reason to do so.

[mabartos]

@geoand Ahh, I didn't know about the issue with inline comments.

It's a super niche example, but as we are talking about LTS, I'd prefer to not backport unless there is a very good reason to do so.

Understandable; we'll probably keep the similar functionality on our side until we are on the next Quarkus LTS.

Thanks!

[geoand]

🙏🏽