Removing cacheability for QuarkusApplicationModelTask - #48530
Merged
aloubyansky merged 1 commit intoJun 23, 2025
Conversation
quarkus-bot
Bot
added
area/devtools
Status for workflow
|
aloubyansky
approved these changes
Jun 23, 2025
Contributor
|
@cdsap @aloubyansky 🚀 Thanks 👍 Is it possible to include this into 3.24.0 already? |
Member
|
@HerrDerb unfortunately, the core artifacts 3.24.0 have already been released. The platform release will be finalized on the 25th. It will be included in the next patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on issue #47926, we initially attempted to address the problem in PR #48290. However, the CI execution revealed failures in the Conditional Dependencies tests. Upon investigation, we found that the proposed fix was resolving the configuration eagerly—before the Conditional Dependencies logic was applied—thereby breaking the expected functionality.
I explored alternative solutions, such as using QuarkusExtensionView in the model task. This worked partially for the same module but did not handle the case described in the original reproducer, where JARs are manually removed.
The root cause of the issue is that ModelTask hits the cache even when the Quarkus version changes, since the version does not affect the application model's classpath. To address this, this PR proposes disabling the cacheability of the ModelTask. This effectively resolves the main issue reported in the original ticket.
As a follow-up, we could explore more targeted solutions—such as introducing a dedicated input for ModelTask that resolves the configuration during execution and captures the dependency versions.
cc @HerrDerb